Improve implementation of getLargestNumber

illicitonion · illicitonion · commit a16150c0c60a · 2024-10-22T16:24:10.000+01:00
diff --git a/challenges/unit-testing/writing-tests/largest-number/largest-number.js b/challenges/unit-testing/writing-tests/largest-number/largest-number.js
@@ -1,7 +1,7 @@
 function getLargestNumber(array) {
-  let largestNumber;
-  for (let i = 0; i < array.length - 1; i++) {
-    if (array[i] > array[i + 1]) {
+  let largestNumber = array[0];
+  for (let i = 0; i < array.length; i++) {
+    if (array[i] > largestNumber) {
       largestNumber = array[i];
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`function getLargestNumber(array) {`
`2`		`- let largestNumber;`
`3`		`- for (let i = 0; i < array.length - 1; i++) {`
`4`		`- if (array[i] > array[i + 1]) {`
	`2`	`+ let largestNumber = array[0];`
	`3`	`+ for (let i = 0; i < array.length; i++) {`
	`4`	`+ if (array[i] > largestNumber) {`
`5`	`5`	`largestNumber = array[i];`
`6`	`6`	`}`
`7`	`7`	`}`