removed test console logs, cleaned up the code and fixed faulty test in querystring test suite

Author: asaniDev

Sprint-2/debug/address.js

@@ -4,7 +4,7 @@
 // This code should log out the houseNumber from the address object
 // but it isn't working...
 // Fix anything that isn't working
-//fixed it by puting "houseNumber" in the square brackets.
+//fixed it by putting "houseNumber" in the square brackets.
 
 const address = {
   houseNumber: 42,

Sprint-2/implement/contains.js

@@ -29,6 +29,4 @@ function contains(checkObj, checkProp) {
   }
 }
 
-contains({ d: "me" }, 4);
-
 module.exports = contains;

Sprint-2/implement/querystring.js

@@ -39,6 +39,4 @@ function parseQueryString(queryString) {
   return queryParams;
 }
 
-console.log(`with ${parseQueryString("equation=x=y+1")}`);
-
 module.exports = parseQueryString;

Sprint-2/implement/querystring.test.js

@@ -26,7 +26,7 @@ test("parses querystring without an =, it should throw an error", () => {
 });
 
 test("if our function is passed only one string but there is no =", () => {
-  expect(parseQueryString("color,brown")).toEqual(
+  expect(() => parseQueryString("color,brown")).toThrow(
     "error invalid format string, no = to separate key value pair"
   );
 });

Sprint-2/implement/tally.js

@@ -27,13 +27,10 @@ function tally(inputArray) {
         tallyObject[tempArray[0]] = tempArray.length;
       }
     }
-    console.log(`the new array and the new object ${tallyObject}`);
     return tallyObject;
   } else {
     throw new Error("error invalid input passed, please provide an array");
   }
 }
 
-console.log(`new object is ${tally(["a", "a", "b", "c", "c", "d", "a"])}`);
-
 module.exports = tally;

Sprint-2/interpret/invert.js

@@ -11,6 +11,16 @@ function invert(obj) {
 
   if (Object.prototype.toString.call(obj) === "[object Object]") {
     for (const [key, value] of Object.entries(obj)) {
+      if (
+        value === null ||
+        Array.isArray(value) ||
+        (typeof value === "object" && !Array.isArray(value))
+      ) {
+        throw new Error(
+          "error invalid input entered, expecting an object to have only strings as values"
+        );
+      }
+
       invertedObj[value] = key;
     }
   } else {
@@ -22,25 +32,6 @@ function invert(obj) {
 
 module.exports = invert;
 
-console.log(
-  `the return value when invert is called with ${invert({
-    cars: { toyota: 2, bmw: 1, benz: 4 },
-  })}`
-);
-
-/*
-for (const property in obj) {
-      if (typeof obj[property] !== "string") {
-        throw new Error(
-          "error invalid input entered, expecting an object to have only strings as values"
-        );
-      } else {
-        
-      }
-    }
-
-*/
-
 // a) What is the current return value when invert is called with { a : 1 }
 //it returns a string describing the object.
 

Sprint-2/interpret/invert.test.js

@@ -21,11 +21,8 @@ describe("tests to see if invert function swaps around the keys and values in a
     ).toEqual({ Birmingham: "city", 345908: "population", 20: "boroughs" });
   });
 });
-
-/*
 test("if invert is passed an object which has an array or object as one of its values, it should throw an error", () => {
-    expect(() => invert({ cars: { toyota: 2, bmw: 1, benz: 4 } })).toThrow(
-      "error invalid input entered, expecting an object to have only strings as values"
-    );
-  });
-*/
+  expect(() => invert({ cars: { toyota: 2, bmw: 1, benz: 4 } })).toThrow(
+    "error invalid input entered, expecting an object to have only strings as values"
+  );
+});