Address the issues from the pull request comments

Author: anosidium

Sprint-3/2-practice-tdd/count.js

@@ -1,4 +1,22 @@
 function countChar(stringOfCharacters, findCharacter) {
+  if (typeof stringOfCharacters !== "string") {
+    throw new TypeError(
+      "The argument for parameter stringOfCharacters is not a String type"
+    );
+  }
+
+  if (typeof findCharacter !== "string") {
+    throw new TypeError(
+      "The argument for parameter findCharacter is not a String type"
+    );
+  }
+
+  if (findCharacter.length !== 1) {
+    throw new Error(
+      "Parameter findCharacter is must contain a single character"
+    );
+  }
+
   return stringOfCharacters.split("").reduce((accumulator, character) => {
     return accumulator + (character === findCharacter ? 1 : 0);
   }, 0);

Sprint-3/2-practice-tdd/count.test.js

@@ -23,9 +23,48 @@ test("should count multiple occurrences of a character", () => {
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
 
-test("should count no occurences of z characters", () => {
+test("should count no occurrences of z characters", () => {
   const str = "aaaaa";
   const char = "z";
   const count = countChar(str, char);
   expect(count).toEqual(0);
 });
+
+test("should return 0 for an empty string and a non-empty character", () => {
+  const str = "";
+  const char = "z";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+test("should return 0 for an empty string and a whitespace character", () => {
+  const str = "";
+  const char = " ";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+test("should return 0 when the string contains the character in a different case", () => {
+  const str = "aBcDeF";
+  const char = "A";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+test("throws error when the first argument is not a string", () => {
+  expect(() => countChar(1234, "1")).toThrow(
+    "The argument for parameter stringOfCharacters is not a String type"
+  );
+});
+
+test("throws error when the second argument is not a string", () => {
+  expect(() => countChar("1234", 1)).toThrow(
+    "The argument for parameter findCharacter is not a String type"
+  );
+});
+
+test("throws error when second argument is longer than one character", () => {
+  expect(() => countChar("1234", "12")).toThrow(
+    "Parameter findCharacter is must contain a single character"
+  );
+});

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -8,11 +8,9 @@ function getOrdinalNumber(num) {
   const lastDigits = Number(numberString.slice(-2));
   let ordinal;
 
-  console.log("lastDigits", lastDigits);
-
   if (num === 0) {
     ordinal = "";
-  } else if (lastDigits === 11) {
+  } else if ([11, 12, 13].includes(lastDigits)) {
     ordinal = "th";
   } else if (lastDigit === 1) {
     ordinal = "st";

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -8,7 +8,7 @@ const getOrdinalNumber = require("./get-ordinal-number");
 // When the number is 1,
 // Then the function should return "1st"
 
-test("should return '@' for ", () => {
+test("should return an empty string for a non-numerical character", () => {
   expect(getOrdinalNumber("@")).toEqual("");
 });
 
@@ -20,6 +20,14 @@ test("should return '11th' for 11", () => {
   expect(getOrdinalNumber(11)).toEqual("11th");
 });
 
+test("should return '12th' for 12", () => {
+  expect(getOrdinalNumber(12)).toEqual("12th");
+});
+
+test("should return '13th' for 13", () => {
+  expect(getOrdinalNumber(13)).toEqual("13th");
+});
+
 test("should return '-11th' for -11", () => {
   expect(getOrdinalNumber(-11)).toEqual("-11th");
 });