Functions, assertions, and invalid ranks tested. Modified the if statement to handle valid numeric literals such as '2.1' and '002'.

Author: Mahtem

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -9,19 +9,16 @@
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
 
-  const rank = card.slice(0,-1);
-  if (rank === "A") {
-    return 11;
-  }
-   else if (["K", "J", "Q", "10"].includes(rank)){
-    return 10;
-   }
-   else if (!isNaN(rank )) {
-    return Number(rank);
-   }
-    else {
-      throw new Error ("Invalid Card");
-    }
+  const rank = card.slice(0, -1);
+  const validRanks = ["A", "K", "Q", "J", "10", "9", "8", "7", "6", "5", "4", "3", "2"];
+
+   if (!validRanks.includes(rank)) {
+    throw new Error("Invalid Card");
+     }
+
+   if (rank === "A") return 11;
+   if (["K", "Q", "J", "10"].includes(rank)) return 10;
+     return Number(rank);
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -88,4 +85,20 @@ try {
   assertEquals(error.message, "Invalid Card");
 }
 
-// Functions, assertion and invalid rank tested
+try {
+  getCardValue("2.1♥"); // decimal — invalid
+  console.log("Test failed: no error thrown for 2.1♥");
+} catch (error) {
+  assertEquals(error.message, "Invalid Card");
+}
+
+try {
+  getCardValue("0002♦"); // padded number — invalid
+  console.log("Test failed: no error thrown for 0002♦");
+} catch (error) {
+  assertEquals(error.message, "Invalid Card");
+}
+
+// Functions, assertion and invalid rank tested, and modified the if statment
+// to hadnle valid numeric literals such as "2.1", "002" "Functions, assertions, and invalid ranks tested. 
+// Modified the if statement to handle valid numeric literals such as '2.1' and '002'. 

Sprint-3/2-practice-tdd/count.test.js

@@ -22,3 +22,53 @@ test("should count multiple occurrences of a character", () => {
 // And a character char that does not exist within the case-sensitive str,
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
+
+test("should return 0 when character does not exist in string", () => {
+  const str = "Code Your Future";
+  const char = "g";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: Empty string 
+
+test("should return 0 when string is empty", () => {
+  const str = "";
+  const char = "a";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: String is a space
+
+test("should return 0 when string is space", () => {
+  const str = "   ";
+  const char = "a";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: String is 
+
+// Scenario: Empty character
+
+test("should return 0 when character is empty", () => {
+  const str = "my code";
+  const char = "";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: char is empty character
+
+test("should return 0 when character is empty string ", () => {
+  const str = "my code";
+  const char = " ";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+
+
+// Scenario: charcter not string 
+