2-is proper-fraction test with jest

Author: enjoy15

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,16 +8,15 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
-    return true;
-  }
-  if (numerator >= denominator) {
+  // First check: both numerator and denominator should be positive
+  if (numerator < 0 || denominator < 0) {
     return false;
   }
-  if (Math.abs(numerator) < Math.abs(denominator)) {
+  
+  // Second check: numerator should be less than denominator
+  if (numerator < denominator) {
     return true;
-  }
-  if (Math.abs(numerator) >= Math.abs(denominator)) {
+  } else {
     return false;
   }
 }

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,7 +7,16 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for an improper fraction", () => {  
+  expect(isProperFraction(5, 3)).toEqual(false);
+});
 
 // Case 3: Identify Negative Fractions:
+test("should return false for a negative fraction", () => {
+  expect(isProperFraction(-2, 3)).toEqual(false);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return false for equal numerator and denominator", () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+});