PR dashboard: Identify PRs that already have a reviewer (#1254)

* Identify PRs that already have a reviewer

* Progressively fill in already-being-reviewed data

This speeds up the initial page load, and adds in more information as
it's known.

Author: illicitonion

org-cyf-itp/assets/custom-scripts/reviews/common.mjs

@@ -13,6 +13,8 @@ function identifyAge(date) {
     }
 }
 
+const apiPrefix = "https://github-issue-proxy.illicitonion.com/cached/2/repos/CodeYourFuture/";
+
 // TODO: Pull these in from config.
 export const modules = [
     "Module-User-Focused-Data",
@@ -33,7 +35,35 @@ class PR {
         this.createdAge = createdAge;
         this.updatedAge = updatedAge;
         this.status = status;
-        this.comments = [];
+        this._didLoadReviews = false;
+        this.reviews = [];
+    }
+
+    async loadReviews() {
+        if (this._didLoadReviews) {
+            return;
+        }
+        const response = await fetch(`${apiPrefix}/${this.module}/pulls/${this.number}/reviews`);
+        const reviews = await response.json();
+        for (const reviewResponse of reviews) {
+            const review = new Review(reviewResponse.user.login, reviewResponse.user.login === this.userName, identifyAge(new Date(Date.parse(reviewResponse["submitted_at"]))), reviewResponse.state);
+            this.reviews.push(review);
+        }
+        this._didLoadReviews = true;
+    }
+
+    hasReviewer() {
+        return this.reviews.some(review => !review.isPrAuthor);
+    }
+}
+
+class Review {
+    constructor(userName, isPrAuthor, age, state) {
+        this.userName = userName;
+        this.isPrAuthor = isPrAuthor;
+        this.age = age;
+        // e.g. "COMMENTED".
+        this.state = state;
     }
 }
 
@@ -58,11 +88,11 @@ function getStatus(state, labels) {
     return "Unknown";
 }
 
-export async function fetchPrs() {
+export async function fetchPrsWithoutLoadingReviews() {
     const prs = [];
     const responsePromises = [];
     for (const module of modules) {
-        responsePromises.push(fetch(`https://github-issue-proxy.illicitonion.com/cached/2/repos/CodeYourFuture/${module}/pulls?state=all`).then((response) => response.json()));
+        responsePromises.push(fetch(`${apiPrefix}/${module}/pulls?state=all`).then((response) => response.json()));
     }
     const responsesByModule = await Promise.all(responsePromises);
     for (let i = 0; i < responsesByModule.length; i++) {

org-cyf-itp/assets/custom-scripts/reviews/index.mjs

@@ -36,7 +36,24 @@ function computeStatusClass(awaitingReview) {
   }
 }
 
+const state = {
+  "prs": null,
+}
+
 async function onLoad() {
+  render();
+  state.prs = (await fetchPrsWithoutLoadingReviews()).filter((pr) => pr.status === "Needs Review");
+  render();
+  await Promise.all(state.prs.map((pr) => pr.loadReviews()));
+  render();
+}
+
+function render() {
+  if (state.prs === null) {
+    document.querySelector("#pr-list").innerText = "Loading...";
+    return;
+  }
+
   for (const module of modules) {
     awaitingReviewByAge[module] = {
       "this week": 0,
@@ -46,9 +63,7 @@ async function onLoad() {
     prsByModule[module] = [];
   }
 
-  for (const pr of (await fetchPrs()).filter(
-    (pr) => pr.status === "Needs Review"
-  )) {
+  for (const pr of state.prs) {
     awaitingReviewByAge[pr.module][pr.updatedAge]++;
     prsByModule[pr.module].push(pr);
   }
@@ -65,6 +80,7 @@ async function onLoad() {
   }
 
   document.querySelector("#pr-list").innerText = "";
+  document.querySelector("#overview").innerText = "";
 
   for (const module of modules) {
     const awaitingReview = awaitingReviewByAge[module];
@@ -105,7 +121,13 @@ async function onLoad() {
           .querySelector("template.pr-in-list")
           .content.cloneNode(true);
 
-        prInList.querySelector(".emoji").innerText = ageToEmoji[pr.updatedAge];
+        const emojiElement = prInList.querySelector(".emoji");
+        if (pr.hasReviewer()) {
+          emojiElement.innerText = "🙋🏾";
+          emojiElement.title = "Has reviewer";
+        } else {
+          emojiElement.innerText = ageToEmoji[pr.updatedAge];
+        }
 
         const prLink = prInList.querySelector("a.pr-link");
         prLink.href = pr.url;