Alec feedbacks

Author: Wolfjawan

src/Components/forms/Acknowledgement.js

@@ -6,7 +6,7 @@ export default ({ onChange, checked, isEmpty }) => {
       <span className="form-acknowledgement-header">
         Acknowledgement: (* Required)
       </span>
-      <div className={`form-check ml-4 pl-4 ${isEmpty && 'is-empty'}`}>
+      <div className={`form-check ml-4 pl-4 mt-2 ${isEmpty && 'is-empty'}`}>
         <input
           className={`form-check-input`}
           type="checkbox"

src/Components/forms/data.json

@@ -137,6 +137,16 @@
     { "id": "iuhiygutf4w3", "name": "", "level": "", "label": "Other" }
   ],
   "GuidePeopleThList": ["A. Guide people", "None", "Some", "Part of a job"],
-  "TechSkillThList": ["B. Teach people coding or UX", "", "", ""],
-  "OtherSkillThList": ["C. Help run Code Your Future", "", "", ""]
+  "TechSkillThList": [
+    "B. Teach people coding or UX",
+    "None",
+    "Some",
+    "Part of a job"
+  ],
+  "OtherSkillThList": [
+    "C. Help run Code Your Future",
+    "None",
+    "Some",
+    "Part of a job"
+  ]
 }

src/Components/forms/helper.js

@@ -23,12 +23,9 @@ export const initialState = {
     lastName: false,
     email: false,
     city: false,
-    tel: false,
     cityId: false,
     interestedInVolunteer: false,
     interestedInCYF: false,
-    industry: false,
-    hearAboutCYF: false,
     acknowledgement: false
   }
 }

src/Components/forms/index.css

@@ -59,7 +59,7 @@
 .contact-interested {
   font-size: 20px;
   line-height: 24px;
-  margin-top: 50px;
+  margin-bottom: 50px;
 }
 .contact-interested a {
   color: green;

src/Components/forms/index.js

@@ -99,12 +99,9 @@ class Forms extends Component {
       firstName,
       lastName,
       email,
-      tel,
       cityId,
       interestedInVolunteer,
       interestedInCYF,
-      industry,
-      hearAboutCYF,
       acknowledgement
     })
     this.validateArray({ guidePeople, techSkill, otherSkill })

src/Components/forms/inputs/index.js

@@ -58,7 +58,7 @@ export default class VolunteerForm extends Component {
             onChange={onChange}
             value={firstName}
             isEmpty={errors.firstName}
-            label="First Name"
+            label="First Name *"
             name="firstName"
             placeholder="Your first name..."
             type="text"
@@ -67,30 +67,30 @@ export default class VolunteerForm extends Component {
             onChange={onChange}
             value={lastName}
             isEmpty={errors.lastName}
-            label="Last Name"
+            label="Last Name *"
             name="lastName"
             placeholder="Your first name..."
             type="text"
           />
-          <PhoneNumber onChange={telOnChange} tel={tel} isEmpty={errors.tel} />
           <TextInput
             onChange={onChange}
             value={email}
             isEmpty={errors.email}
             emailExist={volunteer.userExist}
-            label="Email"
+            label="Email *"
             name="email"
             placeholder="[email protected]"
             type="email"
           />
+          <PhoneNumber onChange={telOnChange} tel={tel} isEmpty={errors.tel} />
         </div>
         <DropDown
           onChange={onChange}
           value={cityId}
           name="cityId"
           arrayList={cities}
           isEmpty={errors.cityId}
-          label="What CYF city do you want to work with?"
+          label="What CYF city do you want to work with? *"
         />
         <p className="contact-interested">
           If you're interested in bringing CYF to your city, email us at
@@ -107,7 +107,7 @@ export default class VolunteerForm extends Component {
           onChange={onChange}
           value={interestedInVolunteer}
           isEmpty={errors.interestedInVolunteer}
-          label="Why are you interested in volunteering?"
+          label="Why are you interested in volunteering? *"
           name="interestedInVolunteer"
           placeholder="Text..."
           type="text"
@@ -116,7 +116,7 @@ export default class VolunteerForm extends Component {
           onChange={onChange}
           value={interestedInCYF}
           isEmpty={errors.interestedInCYF}
-          label="Why are you interested in Code Your Future?"
+          label="Why are you interested in Code Your Future? *"
           name="interestedInCYF"
           placeholder="Text..."
           type="text"