Skip to content

Commit f309ba1

Browse files
committed
Update test and accessing response from api
1 parent 68dcc7b commit f309ba1

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

e2e/integration/journey.test.js

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ beforeEach(() => {
99
})
1010
cy.intercept('GET', `${mockServerURL}/employers`, {
1111
fixture: 'employers.json'
12-
}).as('getEmployers')
12+
})
1313
cy.visit('/')
1414
})
1515

@@ -125,21 +125,13 @@ it('requires employee selection', () => {
125125
cy.findByRole('button', { name: /submit/i }).click()
126126
cy.findByText(/form is incomplete/i).should('exist')
127127
cy.findByRole('combobox', { name: /who is your employer/i }).type(
128-
'Capgemini{enter}'
128+
'Cap{enter}'
129129
)
130130
cy.findByRole('button', { name: /submit/i }).click()
131131

132132
cy.wait('@createVolunteer').then(({ request: { body: payload } }) => {
133133
expect(payload).to.have.property('hearAboutCYF', 'Employer')
134-
expect(payload).to.have.property('employer', 'Capgemini')
135-
})
136-
137-
cy.wait('@getEmployers').then(res => {
138-
const employers = res.response.body.employers
139-
expect(res.response.statusCode).to.equal(200)
140-
expect(employers).to.be.an('array')
141-
expect(employers).to.have.length.above(0)
142-
expect(employers).to.deep.include({ _id: '6569', name: 'Capgemini' })
134+
expect(payload).to.have.property('employer', '6569')
143135
})
144136
})
145137

src/Components/forms/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ class Forms extends Component {
3838

3939
fetchEmployers = async () => {
4040
try {
41-
const employersResponse = await axios.get(`${domain()}/employers`)
42-
const employersData = employersResponse.data
41+
const response = await axios.get(`${domain()}/employers`)
42+
const employersData = response.data.employers
4343
employersData.sort((a, b) => a.name.localeCompare(b.name))
4444
this.setState({ employersOptions: employersData })
4545
} catch (err) {

0 commit comments

Comments
 (0)