Skip to content

Conversation

illicitonion
Copy link
Member

We want to be able to rely on regions for filtering, e.g. when showing things in dashboards.

Ideally we would have a source of truth of which region each trainee is in, but we don't, so in the mean time check that the title claims to be in some region.

Hard-code the known regions for now - ideally an API will provide these in the future.

@illicitonion illicitonion requested a review from AnnaFYZ August 7, 2025 14:52
We want to be able to rely on regions for filtering, e.g. when showing
things in dashboards.

Ideally we would have a source of truth of which region each trainee is
in, but we don't, so in the mean time check that the title claims to be
in some region.

Hard-code the known regions for now - ideally an API will provide these
in the future.
Copy link
Collaborator

@AnnaFYZ AnnaFYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the result comment is left on the PR if region is not mentioned or is not in expected values in the PR's title

@illicitonion illicitonion merged commit 80c0e9d into main Aug 14, 2025
3 checks passed
@illicitonion illicitonion deleted the pr-region-matching branch August 14, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants