Skip to content

Commit 9780410

Browse files
authored
fix: fixes a monaco editor display bug for lines below 14-17
There was some css added to monaco-editor that allowed cypress tests to pass without axe issues. But this caused a bug with lines below the set height to not be shown in the editor. Here, I've removed that css, and I've made a PR to monolith that skips that axe check until we are able to add it back in DISC-529. Root cause: dequelabs/axe-core#2806
1 parent 0f36904 commit 9780410

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

packages/codebytes/src/codeByteEditor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export const CodeByteEditor: React.FC<CodeByteEditorProps> = ({
5656
}, [trackingData]);
5757

5858
return (
59-
<EditorContainer bg="black" maxWidth="43rem" {...rest}>
59+
<EditorContainer bg="black" maxWidth="43rem" {...rest} overflow="hidden">
6060
<Box borderBottom={1} borderColor="gray-900" py={4} pl={8}>
6161
<IconButton
6262
icon={FaviconIcon}

packages/codebytes/src/drawers.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ const RightDrawerIcon = LeftDrawerIcon.withComponent(ArrowChevronRightIcon);
1717

1818
const Drawer = styled(FlexBox)<{ open?: boolean; hideOnClose?: boolean }>`
1919
position: relative;
20-
// A hidden overflowing element causes accessibility errors
21-
// The background of the overflowing element causes triggers color contrast errors
22-
& .lines-content {
23-
height: 100% !important;
24-
}
2520
${({ open, hideOnClose }) => `
2621
flex-basis: ${open ? '100%' : '0%'};
2722
visibility: ${!open && hideOnClose ? 'hidden' : 'visible'};

0 commit comments

Comments
 (0)