reformatted code

Author: DavertMik

src/Codeception/Module/SOAP.php

@@ -37,8 +37,8 @@
 class SOAP extends \Codeception\Module
 {
 
-    protected $config = array('schema' => "", 'schema_url' => 'http://schemas.xmlsoap.org/soap/envelope/');
-    protected $requiredFields = array('endpoint');
+    protected $config = ['schema' => "", 'schema_url' => 'http://schemas.xmlsoap.org/soap/envelope/'];
+    protected $requiredFields = ['endpoint'];
     /**
      * @var \Symfony\Component\BrowserKit\Client
      */
@@ -67,11 +67,14 @@ public function _before(\Codeception\TestCase $test)
                     }
                 }
             } else {
-                if (!$this->hasModule('PhpBrowser'))
+                if (!$this->hasModule('PhpBrowser')) {
                     throw new \Codeception\Exception\ModuleConfig(__CLASS__, "For Soap testing via HTTP please enable PhpBrowser module");
+                }
                 $this->client = $this->getModule('PhpBrowser')->client;
             }
-            if (!$this->client) throw new \Codeception\Exception\ModuleConfig(__CLASS__, "Client for SOAP requests not initialized.\nProvide either PhpBrowser module or Framework module which shares FrameworkInterface");
+            if (!$this->client) {
+                throw new \Codeception\Exception\ModuleConfig(__CLASS__, "Client for SOAP requests not initialized.\nProvide either PhpBrowser module or Framework module which shares FrameworkInterface");
+            }
         }
 
         $this->buildRequest();
@@ -104,7 +107,7 @@ public function _before(\Codeception\TestCase $test)
      * @param $header
      * @param array $params
      */
-    public function haveSoapHeader($header, $params = array())
+    public function haveSoapHeader($header, $params = [])
     {
         $soap_schema_url = $this->config['schema_url'];
         $xml = $this->xmlRequest;
@@ -271,7 +274,8 @@ public function dontSeeSoapResponseIncludes($xml)
      *
      * @param $xml
      */
-    public function seeSoapResponseContainsStructure($xml) {
+    public function seeSoapResponseContainsStructure($xml)
+    {
         $xml = SoapUtils::toXml($xml);
         $this->debugSection("Structure", $xml->saveXML());
         $root = $xml->firstChild;
@@ -280,7 +284,9 @@ public function seeSoapResponseContainsStructure($xml) {
 
         $els = $this->xmlResponse->getElementsByTagName($root->nodeName);
 
-        if (empty($els)) return \PHPUnit_Framework_Assert::fail("Element {$root->nodeName} not found in response");
+        if (empty($els)) {
+            return \PHPUnit_Framework_Assert::fail("Element {$root->nodeName} not found in response");
+        }
 
         $matches = false;
         foreach ($els as $node) {
@@ -305,7 +311,9 @@ public function seeSoapResponseContainsXPath($xpath)
     {
         $path = new \DOMXPath($this->xmlResponse);
         $res = $path->query($xpath);
-        if ($res === false) $this->fail("XPath selector is malformed");
+        if ($res === false) {
+            $this->fail("XPath selector is malformed");
+        }
         $this->assertGreaterThan(0, $res->length);
     }
 
@@ -324,18 +332,20 @@ public function dontSeeSoapResponseContainsXPath($xpath)
     {
         $path = new \DOMXPath($this->xmlResponse);
         $res = $path->query($xpath);
-        if ($res === false) $this->fail("XPath selector is malformed");
+        if ($res === false) {
+            $this->fail("XPath selector is malformed");
+        }
         $this->assertEquals(0, $res->length);
     }
 
 
-
     /**
      * Checks response code from server.
      *
      * @param $code
      */
-    public function seeResponseCodeIs($code) {
+    public function seeResponseCodeIs($code)
+    {
         \PHPUnit_Framework_Assert::assertEquals($code, $this->client->getInternalResponse()->getStatus(), "soap response code matches expected");
     }
 
@@ -347,7 +357,8 @@ public function seeResponseCodeIs($code) {
      * @param $cssOrXPath
      * @return string
      */
-    public function grabTextContentFrom($cssOrXPath) {
+    public function grabTextContentFrom($cssOrXPath)
+    {
         $el = $this->matchElement($cssOrXPath);
         return $el->textContent;
     }
@@ -361,9 +372,12 @@ public function grabTextContentFrom($cssOrXPath) {
      * @param $attribute
      * @return string
      */
-    public function grabAttributeFrom($cssOrXPath, $attribute) {
+    public function grabAttributeFrom($cssOrXPath, $attribute)
+    {
         $el = $this->matchElement($cssOrXPath);
-        if (!$el->hasAttribute($attribute)) $this->fail("Attribute not found in element matched by '$cssOrXPath'");
+        if (!$el->hasAttribute($attribute)) {
+            $this->fail("Attribute not found in element matched by '$cssOrXPath'");
+        }
         return $el->getAttribute($attribute);
     }
 
@@ -377,8 +391,11 @@ protected function matchElement($cssOrXPath)
         try {
             $selector = \Symfony\Component\CssSelector\CssSelector::toXPath($cssOrXPath);
             $els = $xpath->query($selector);
-            if ($els) return $els->item(0);
-        } catch (\Symfony\Component\CssSelector\Exception\ParseException $e) {}
+            if ($els) {
+                return $els->item(0);
+            }
+        } catch (\Symfony\Component\CssSelector\Exception\ParseException $e) {
+        }
         $els = $xpath->query($cssOrXPath);
         if ($els) {
             return $els->item(0);
@@ -394,10 +411,14 @@ protected function structureMatches($schema, $xml)
             foreach ($xml->childNodes as $node2) {
                 if ($node1->nodeName == $node2->nodeName) {
                     $matched = $this->structureMatches($node1, $node2);
-                    if ($matched) break;
+                    if ($matched) {
+                        break;
+                    }
                 }
             }
-            if (!$matched) return false;
+            if (!$matched) {
+                return false;
+            }
         }
         return true;
     }
@@ -434,14 +455,16 @@ protected function buildRequest()
 
     protected function processRequest($action, $body)
     {
-        $this->client->request('POST',
-        $this->config['endpoint'],
-        array(), array(),
-        array(
-            "HTTP_Content-Type" => "text/xml; charset=UTF-8",
-            'HTTP_Content-Length' => strlen($body),
-            'HTTP_SOAPAction' => $action),
-        $body
+        $this->client->request(
+            'POST',
+            $this->config['endpoint'],
+            [], [],
+            [
+                "HTTP_Content-Type"   => "text/xml; charset=UTF-8",
+                'HTTP_Content-Length' => strlen($body),
+                'HTTP_SOAPAction'     => $action
+            ],
+            $body
         );
     }
 
@@ -453,7 +476,7 @@ protected function processInternalRequest($action, $body)
             $this->processRequest($action, $body);
         } catch (\ErrorException $e) {
             // Zend_Soap outputs warning as an exception
-            if (strpos($e->getMessage(),'Warning: Cannot modify header information')===false) {
+            if (strpos($e->getMessage(), 'Warning: Cannot modify header information') === false) {
                 ob_end_clean();
                 throw $e;
             }