No more conflict between SOAP and REST (#3532)

* Remove SOAP conflict with API interface

* deprecated seeResponseCodeIs use seeSoapResponseCodeIs instead

* Update SOAP Test to remove conflicts with api

Author: eXorus

src/Codeception/Module/SOAP.php

@@ -1,7 +1,6 @@
 <?php
 namespace Codeception\Module;
 
-use Codeception\Lib\Interfaces\ConflictsWithModule;
 use Codeception\Lib\Interfaces\DependsOnModule;
 use Codeception\Module as CodeceptionModule;
 use Codeception\TestInterface;
@@ -11,7 +10,6 @@
 use Codeception\Lib\InnerBrowser;
 use Codeception\Util\Soap as SoapUtils;
 use Codeception\Util\XmlStructure;
-use Codeception\Lib\Interfaces\API;
 
 /**
  * Module for testing SOAP WSDL web services.
@@ -43,21 +41,17 @@
  * * xmlRequest - last SOAP request (DOMDocument)
  * * xmlResponse - last SOAP response (DOMDocument)
  *
- * ## Conflicts
- *
- * Conflicts with REST module
- *
  */
-class SOAP extends CodeceptionModule implements DependsOnModule, API, ConflictsWithModule
+class SOAP extends CodeceptionModule implements DependsOnModule
 {
     protected $config = [
         'schema' => "",
         'schema_url' => 'http://schemas.xmlsoap.org/soap/envelope/',
         'framework_collect_buffer' => true
     ];
-    
+
     protected $requiredFields = ['endpoint'];
-    
+
     protected $dependencyMessage = <<<EOF
 Example using PhpBrowser as backend for SOAP module.
 --
@@ -114,19 +108,14 @@ public function _depends()
         return ['Codeception\Lib\InnerBrowser' => $this->dependencyMessage];
     }
 
-    public function _conflicts()
-    {
-        return 'Codeception\Lib\Interfaces\API';
-    }
-
     public function _inject(InnerBrowser $connectionModule)
     {
         $this->connectionModule = $connectionModule;
         if ($connectionModule instanceof Framework) {
             $this->isFunctional = true;
         }
     }
-    
+
     private function getClient()
     {
         if (!$this->client) {
@@ -142,15 +131,15 @@ private function getXmlResponse()
         }
         return $this->xmlResponse;
     }
-    
+
     private function getXmlStructure()
     {
         if (!$this->xmlStructure) {
             $this->xmlStructure = new XmlStructure($this->getXmlResponse());
         }
         return $this->xmlStructure;
     }
-    
+
     /**
      * Prepare SOAP header.
      * Receives header name and parameters as array.
@@ -400,7 +389,7 @@ public function dontSeeSoapResponseContainsXPath($xpath)
      *
      * @param $code
      */
-    public function seeResponseCodeIs($code)
+    public function seeSoapResponseCodeIs($code)
     {
         $this->assertEquals(
             $code,
@@ -409,6 +398,14 @@ public function seeResponseCodeIs($code)
         );
     }
 
+    /**
+     * @deprecated use seeSoapResponseCodeIs instead
+     */
+    public function seeResponseCodeIs($code)
+    {
+        $this->seeSoapResponseCodeIs($code);
+    }
+
     /**
      * Finds and returns text contents of element.
      * Element is matched by either CSS or XPath

tests/unit/Codeception/Module/SoapTest.php

@@ -29,12 +29,6 @@ public function setUp()
         $this->module->_before(Stub::makeEmpty('\Codeception\Test\Test'));
         $this->module->client = Stub::makeEmpty('\Codeception\Lib\Connector\Universal');
     }
-
-    public function testConflictsWithAPI()
-    {
-        $this->assertInstanceOf('Codeception\Lib\Interfaces\ConflictsWithModule', $this->module);
-        $this->assertEquals('Codeception\Lib\Interfaces\API', $this->module->_conflicts());
-    }
 
     public function testXmlIsBuilt()
     {