Skip to content

Commit fb82b42

Browse files
committed
Fixed test compatibility with PHPUnit 9
1 parent 32f5700 commit fb82b42

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ jobs:
2424
run: composer validate
2525

2626
- name: Install dependencies
27-
run: |
28-
composer require phpunit/phpunit "<=8.5.2" --no-update --ignore-platform-reqs
29-
composer install --prefer-dist --no-progress --no-interaction --no-suggest
27+
run: composer install --prefer-dist --no-progress --no-interaction --no-suggest
3028

3129
- name: Run test suite
3230
run: php vendor/bin/codecept run

src/Codeception/Module/SOAP.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
<?php
22
namespace Codeception\Module;
33

4-
use Codeception\Lib\Interfaces\API;
54
use Codeception\Lib\Interfaces\DependsOnModule;
6-
use Codeception\Lib\Notification;
75
use Codeception\Module as CodeceptionModule;
86
use Codeception\TestInterface;
97
use Codeception\Exception\ModuleException;

tests/unit/Codeception/Module/SoapTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ public function testXmlIsBuilt()
3737
{
3838
$dom = new \DOMDocument();
3939
$dom->load($this->layout);
40-
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
4140
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
4241
}
4342

@@ -50,7 +49,7 @@ public function testBuildHeaders()
5049
$header->appendChild($dom->createElement('username', 'davert'));
5150
$header->appendChild($dom->createElement('password', '123456'));
5251
$dom->documentElement->getElementsByTagName('Header')->item(0)->appendChild($header);
53-
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
52+
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
5453
}
5554

5655
public function testBuildRequest()
@@ -65,7 +64,7 @@ public function testBuildRequest()
6564
$request = $dom->createElement('ns:KillHumans');
6665
$request->appendChild($body);
6766
$dom->documentElement->getElementsByTagName('Body')->item(0)->appendChild($request);
68-
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
67+
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
6968
}
7069

7170
public function testBuildRequestWithDomNode()
@@ -80,7 +79,7 @@ public function testBuildRequestWithDomNode()
8079
$dom->documentElement->getElementsByTagName('Body')->item(0)->appendChild($request);
8180

8281
$this->module->sendSoapRequest('KillHumans', $body);
83-
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
82+
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
8483
}
8584

8685
public function testSeeXmlIncludes()

0 commit comments

Comments
 (0)