[Yii] Splitted cleanup and transactional configuration (#4379)

* Splitted `cleanup` and `transactional` configuration

* Avoid BC with `transaction` setting

* Fixes code style

* Fixes code style

* Fixes `rollBack` method invocation

Author: leandrogehlen

src/Codeception/Module/Yii2.php

@@ -22,7 +22,8 @@
  * * `configFile` *required* - the path to the application config file. File should be configured for test environment and return configuration array.
  * * `entryUrl` - initial application url (default: http://localhost/index-test.php).
  * * `entryScript` - front script title (like: index-test.php). If not set - taken from entryUrl.
- * * `cleanup` - (default: true) wrap all database connection inside a transaction and roll it back after the test. Should be disabled for acceptance testing..
+ * * `transaction` - (default: true) wrap all database connection inside a transaction and roll it back after the test. Should be disabled for acceptance testing..
+ * * `cleanup` - (default: true) cleanup fixtures after the test
  *
  * You can use this module by setting params in your functional.suite.yml:
  *
@@ -77,7 +78,8 @@
  *         - Yii2:
  *             configFile: 'config/test.php'
  *             part: ORM # allow to use AR methods
- *             cleanup: false # don't wrap test in transaction
+ *             transaction: false # don't wrap test in transaction
+ *             cleanup: false # don't cleanup the fixtures
  *             entryScript: index-test.php
  * ```
  *
@@ -91,7 +93,7 @@
  * $I->haveFixtures(['posts' => PostsFixture::className()]);
  * ```
  *
- * or, if you need to load fixtures before the test (probably before the cleanup transaction is started), you
+ * or, if you need to load fixtures before the test, you
  * can specify fixtures with `_fixtures` method of a testcase:
  *
  * ```php
@@ -131,6 +133,7 @@ class Yii2 extends Framework implements ActiveRecord, PartedModule
      */
     protected $config = [
         'cleanup'     => true,
+        'transaction' => null,
         'entryScript' => '',
         'entryUrl'    => 'http://localhost/index-test.php',
     ];
@@ -150,6 +153,10 @@ class Yii2 extends Framework implements ActiveRecord, PartedModule
 
     public function _initialize()
     {
+        if ($this->config['transaction'] === null) {
+            $this->config['transaction'] = $this->config['cleanup'];
+        }
+
         if (!is_file(Configuration::projectDir() . $this->config['configFile'])) {
             throw new ModuleConfigException(
                 __CLASS__,
@@ -184,7 +191,7 @@ public function _before(TestInterface $test)
             $this->loadFixtures($test);
         }
 
-        if ($this->config['cleanup']
+        if ($this->config['transaction']
             && $this->app->has('db')
             && $this->app->db instanceof \yii\db\Connection
         ) {
@@ -221,13 +228,12 @@ public function _after(TestInterface $test)
                 $fixture->unloadFixtures();
             }
             $this->loadedFixtures = [];
-
-            if ($this->transaction) {
-                $this->transaction->rollback();
-                $this->debugSection('Database', 'Transaction cancelled; all changes reverted.');
-            }
         }
-
+      
+        if ($this->config['transaction'] && $this->transaction) {
+            $this->transaction->rollBack();
+            $this->debugSection('Database', 'Transaction cancelled; all changes reverted.');
+        }
 
         if ($this->client) {
             $this->client->resetPersistentVars();