Merge pull request BenPru#413 from rhammen/translation_updates

Translation and code fixes for all hassfest errors, except "Error: R] [MANIFEST] Domain does not match dir name"

Author: AJediIAm

.github/workflows/hassfest.yml

@@ -1,8 +1,6 @@
 name: Validate with hassfest
 
 on:
-  schedule:
-    - cron: "0 0 * * 0"
   workflow_dispatch:
 
 jobs:

custom_components/luxtronik/common.py

@@ -72,6 +72,24 @@ def correct_key_value(
     sensor_id: str | LP | LC | LV,
 ) -> Any:
     """Handle special value corrections."""
+    # fix 'states may not contain spaces ea for valid translations'
+    if (
+        sensor_id in [
+        LC.C0080_STATUS,
+        LC.C0117_STATUS_LINE_1,
+        LC.C0119_STATUS_LINE_3,
+        ]
+    ):
+        value = value.replace(' ','_').replace('/','_').lower() 
+    if (
+        sensor_id in [
+        LC.C0100_ERROR_REASON,
+        # LP.P0716_0720_SWITCHOFF_REASON,
+        ]
+        and ((value == -1) or (value == "-1"))
+    ):
+        value = "minus_1"
+        
     if (
         sensor_id == LC.C0080_STATUS
         and value == LuxOperationMode.heating

custom_components/luxtronik/const.py

@@ -36,7 +36,7 @@
 UPDATE_INTERVAL_VERY_SLOW: Final = timedelta(minutes=5)
 
 
-SECOUND_TO_HOUR_FACTOR: Final = 0.000277777777778
+SECOND_TO_HOUR_FACTOR: Final = (1/3600)
 # endregion Constants Main
 
 # region Conf
@@ -124,12 +124,12 @@ class LuxOperationMode(StrEnum):
     """Lux Operation modes heating, hot water etc."""
 
     heating: Final = "heating"  # 0
-    domestic_water: Final = "hot water"  # 1
-    swimming_pool_solar: Final = "swimming pool/solar"  # 2
+    domestic_water: Final = "hot_water"  # 1
+    swimming_pool_solar: Final = "swimming_pool_solar"  # 2
     evu: Final = "evu"  # 3
     defrost: Final = "defrost"  # 4
-    no_request: Final = "no request"  # 5
-    heating_external_source: Final = "heating external source"  # 6
+    no_request: Final = "no_request"  # 5
+    heating_external_source: Final = "heating_external_source"  # 6
     cooling: Final = "cooling"  # 7
 
 
@@ -146,16 +146,16 @@ class LuxMode(StrEnum):
 class LuxStatus1Option(StrEnum):
     """LuxStatus1 option defrost etc."""
 
-    heatpump_running: Final = "heatpump running"
-    heatpump_idle: Final = "heatpump idle"
-    heatpump_coming: Final = "heatpump coming"
-    heatpump_shutdown: Final = "heatpump shutdown"
-    errorcode_slot_zero: Final = "errorcode slot 0"
+    heatpump_running: Final = "heatpump_running"
+    heatpump_idle: Final = "heatpump_idle"
+    heatpump_coming: Final = "heatpump_coming"
+    heatpump_shutdown: Final = "heatpump_shutdown"
+    errorcode_slot_zero: Final = "errorcode_slot_0"
     defrost: Final = "defrost"
-    witing_on_LIN_connection: Final = "witing on LIN connection"
-    compressor_heating_up: Final = "compressor heating up"
-    pump_forerun: Final = "pump forerun"
-    compressor_heater: Final = "compressor heater"
+    waiting_on_lin_connection: Final = "witing_on_LIN_connection"
+    compressor_heating_up: Final = "compressor_heating_up"
+    pump_forerun: Final = "pump_forerun"
+    compressor_heater: Final = "compressor_heater"
 
 
 class LuxStatus3Option(StrEnum):
@@ -164,23 +164,23 @@ class LuxStatus3Option(StrEnum):
     unknown: Final = ("unknown",)
     none: Final = ("none",)
     heating: Final = ("heating",)
-    no_request: Final = ("no request",)
-    grid_switch_on_delay: Final = ("grid switch on delay",)
-    cycle_lock: Final = ("cycle lock",)
-    lock_time: Final = ("lock time",)
-    domestic_water: Final = ("domestic water",)
-    info_bake_out_program: Final = ("info bake out program",)
+    no_request: Final = ("no_request",)
+    grid_switch_on_delay: Final = ("grid_switch_on_delay",)
+    cycle_lock: Final = ("cycle_lock",)
+    lock_time: Final = ("lock_time",)
+    domestic_water: Final = ("domestic_water",)
+    info_bake_out_program: Final = ("info_bake_out_program",)
     defrost: Final = ("defrost",)
-    pump_forerun: Final = ("pump forerun",)
-    thermal_desinfection: Final = ("thermal desinfection",)
+    pump_forerun: Final = ("pump_forerun",)
+    thermal_desinfection: Final = ("thermal_desinfection",)
     cooling: Final = ("cooling",)
-    swimming_pool_solar: Final = ("swimming pool/solar",)
-    heating_external_energy_source: Final = ("heating external energy source",)
+    swimming_pool_solar: Final = ("swimming_pool_solar",)
+    heating_external_energy_source: Final = ("heating_external_energy_source",)
     domestic_water_external_energy_source: Final = (
-        "domestic water external energy source",
+        "domestic_water_external_energy_source",
     )
-    flow_monitoring: Final = ("flow monitoring",)
-    second_heat_generator_1_active: Final = ("second heat generator 1 active",)
+    flow_monitoring: Final = ("flow_monitoring",)
+    second_heat_generator_1_active: Final = ("second_heat_generator_1_active",)
 
 
 class LuxMkTypes(Enum):

custom_components/luxtronik/manifest.json

@@ -1,24 +1,14 @@
 {
   "domain": "luxtronik2",
   "name": "Luxtronik",
-  "config_flow": true,
-  "documentation": "https://github.com/BenPru/luxtronik",
-  "requirements": [
-    "luxtronik==0.3.14",
-    "requests>=2.28.2",
-    "getmac==0.8.2",
-    "packaging>=24.2"
-  ],
-  "issue_tracker": "https://github.com/BenPru/luxtronik/issues",
-  "dependencies": [
-    "http"
-  ],
   "after_dependencies": [],
   "codeowners": [
     "@BenPru"
   ],
-  "iot_class": "local_polling",
-  "version": "2025.7.20",
+  "config_flow": true,
+  "dependencies": [
+    "http"
+  ],
   "dhcp": [
     {
       "macaddress": "000E8C*"
@@ -42,8 +32,18 @@
       "hostname": "wp-novelan"
     }
   ],
+  "documentation": "https://github.com/BenPru/luxtronik",
   "integration_type": "hub",
+  "iot_class": "local_polling",
+  "issue_tracker": "https://github.com/BenPru/luxtronik/issues",
   "loggers": [
     "luxtronik"
-  ]
+  ],
+  "requirements": [
+    "luxtronik==0.3.14",
+    "requests>=2.28.2",
+    "getmac==0.8.2",
+    "packaging>=24.2"
+  ],
+  "version": "2025.7.20"
 }

custom_components/luxtronik/sensor_entities_predefined.py

@@ -15,7 +15,7 @@
 
 from .const import (
     LUX_STATE_ICON_MAP,
-    SECOUND_TO_HOUR_FACTOR,
+    SECOND_TO_HOUR_FACTOR,
     UPDATE_INTERVAL_NORMAL,
     UPDATE_INTERVAL_SLOW,
     UPDATE_INTERVAL_VERY_SLOW,
@@ -106,7 +106,7 @@
         entity_registry_visible_default=False,
         device_class=SensorDeviceClass.ENUM,
         options=[e.value for e in LuxStatus1Option],
-        # translation_key="status1",
+#        translation_key="status_line_1",
     ),
     descr(
         key=SensorKey.STATUS_LINE_2,
@@ -116,7 +116,7 @@
         entity_registry_visible_default=False,
         device_class=SensorDeviceClass.ENUM,
         options=["since", "in"],
-        # translation_key="status2",
+#        translation_key="status_line_2",
     ),
     descr(
         key=SensorKey.STATUS_LINE_3,
@@ -126,7 +126,7 @@
         entity_registry_visible_default=False,
         device_class=SensorDeviceClass.ENUM,
         options=[e.value for e in LuxStatus3Option],
-        # translation_key="status3",
+ #       translation_key="status_line_3",
     ),
     descr(
         key=SensorKey.HEAT_SOURCE_INPUT_TEMPERATURE,
@@ -175,7 +175,7 @@
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
         visibility=LV.V0080_COMPRESSOR1_OPERATION_HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),
@@ -197,7 +197,7 @@
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
         visibility=LV.V0083_COMPRESSOR2_OPERATION_HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),
@@ -208,7 +208,7 @@
         state_class=SensorStateClass.TOTAL_INCREASING,
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),
@@ -327,7 +327,7 @@
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
         visibility=LV.V0086_ADDITIONAL_HEAT_GENERATOR_OPERATION_HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),
@@ -339,7 +339,7 @@
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
         visibility=LV.V0087_ADDITIONAL_HEAT_GENERATOR2_OPERATION_HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),
@@ -597,7 +597,7 @@
         state_class=SensorStateClass.TOTAL_INCREASING,
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),
@@ -679,7 +679,7 @@
         icon="mdi:timer-sand",
         state_class=SensorStateClass.TOTAL_INCREASING,
         native_unit_of_measurement=UnitOfTime.HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),
@@ -737,7 +737,7 @@
         state_class=SensorStateClass.TOTAL_INCREASING,
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         visibility=LV.V0038_SOLAR_COLLECTOR,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
@@ -752,7 +752,7 @@
         state_class=SensorStateClass.TOTAL_INCREASING,
         entity_category=EntityCategory.DIAGNOSTIC,
         native_unit_of_measurement=UnitOfTime.HOURS,
-        factor=SECOUND_TO_HOUR_FACTOR,
+        factor=SECOND_TO_HOUR_FACTOR,
         native_precision=2,
         update_interval=UPDATE_INTERVAL_VERY_SLOW,
     ),