Skip to content

Commit 00be593

Browse files
refactor: clean up code
1 parent d0a16d7 commit 00be593

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

includes/admin/feedzy-rss-feeds-admin.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -949,11 +949,6 @@ public function feedzy_category_columns( $columns ) {
949949
}
950950

951951
$new_columns = $this->array_insert_before( 'slug', $columns, 'source', __( 'Source', 'feedzy-rss-feeds' ) );
952-
if ( $new_columns ) {
953-
$columns = $new_columns;
954-
} else {
955-
$columns['Source'] = __( 'source', 'feedzy-rss-feeds' );
956-
}
957952

958953
return $columns;
959954
}
@@ -1002,7 +997,7 @@ public function manage_feedzy_category_columns( $column, $post_id ) {
1002997
case 'source':
1003998
$src = get_post_meta( $post_id, 'feedzy_category_feed', true );
1004999
if ( empty( $src ) ) {
1005-
$src = __( 'No Source Configured', 'feedzy-rss-feeds' );
1000+
$src = __( 'No Source Configured', 'feedzy-rss-feeds' );
10061001
} else {
10071002
$urls = $this->normalize_urls( $src );
10081003
$src = '';

includes/feedzy-rss-feeds-activator.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,15 @@ public static function add_feeds_group() {
8282

8383
$news_group = wp_insert_post( $group_args );
8484

85-
$feed_groups = 'https://themeisle.com/blog/feed/, https://wptavern.com/feed/, https://www.wpbeginner.com/feed/, https://wpshout.com/feed/, https://planet.wordpress.org/feed/';
85+
$default_feed_urls = array(
86+
'https://themeisle.com/blog/feed/',
87+
'https://wptavern.com/feed/',
88+
'https://www.wpbeginner.com/feed/',
89+
'https://wpshout.com/feed/',
90+
'https://planet.wordpress.org/feed/',
91+
);
92+
93+
$feed_groups = implode( ', ', array_map( 'esc_url', $default_feed_urls ) );
8694

8795
add_post_meta( $news_group, 'feedzy_category_feed', $feed_groups );
8896

js/categories.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,12 @@
3737
// validate feeds group.
3838
function validateFeeds() {
3939
$('#feedzy_category_feeds textarea[name="feedzy_category_feed"]').on('input', function() {
40-
if ($(this).val().length < 1) {
41-
$('.validate-feeds').attr('disabled', true);
42-
} else {
43-
$('.validate-feeds').attr('disabled', false);
44-
}
40+
$('.validate-feeds').attr('disabled', 1 > $(this).val().length );
4541
});
4642

4743
$('#feedzy_category_feeds .button.validate-feeds').on('click', function(e) {
4844
e.preventDefault();
49-
var button = $(this);
45+
const button = $(this);
5046
button.attr('disabled', true);
5147
$('#feedzy_category_feeds .spinner').addClass('is-active');
5248
$.ajax({

0 commit comments

Comments
 (0)