fix: image handling in Feedzy RSS Feeds (#1107)

Add a simple verification function for valid image URLs.

Author: RaduCristianPopescu

includes/abstract/feedzy-rss-feeds-admin-abstract.php

@@ -1173,7 +1173,7 @@ private function render_content( $sc, $feed, $feed_url, $content = '' ) {
 					sprintf( $anchor2, esc_url( $item['item_url'] ), esc_attr( $item['item_url_target'] ), esc_attr( $item['item_url_follow'] ), wp_kses_post( $item['item_title'] ) ),
 					$details
 				);
-			} else {
+			} else { 
 				$content .= sprintf(
 					$line_item,
 					wp_kses_post( $item['itemAttr'] ),
@@ -1616,14 +1616,38 @@ private function get_feed_item_filter( $sc, $sizes, $item, $feed_url, $index, $i
 		return $item_array;
 	}
 
+	/**
+	 * Check if the URL is an image URL based on its extension.
+	 * 
+	 * @param string|null $url The URL to check.
+	 * @return bool
+	 */
+	public function is_image_url( $url ) {
+		if ( empty( $url ) || ! is_string( $url ) ) {
+			return false;
+		}
+
+		$image_extensions = array( 'jpg', 'jpeg', 'png', 'gif', 'webp', 'svg', 'bmp', 'tiff', 'tif', 'avif' );
+		$url_parts        = wp_parse_url( $url );
+		if ( ! isset( $url_parts['path'] ) ) {
+			return false;
+		}
+
+		$path_info = pathinfo( $url_parts['path'] );
+		return (
+			isset( $path_info['extension'] ) &&
+			in_array( strtolower( $path_info['extension'] ), $image_extensions )
+		);
+	}
+
 	/**
 	 * Retrive image from the item object
 	 *
 	 * @since   3.0.0
 	 * @access  public
 	 *
-	 * @param   object $item The item object.
-	 * @param   array  $sc The shorcode attributes array.
+	 * @param   SimplePie\Item $item The item object.
+	 * @param   array          $sc The shorcode attributes array.
 	 *
 	 * @return  string
 	 */
@@ -1640,38 +1664,40 @@ public function feedzy_retrieve_image( $item, $sc = null ) {
 		$the_thumbnail = '';
 		$enclosures    = $item->get_enclosures();
 		if ( $enclosures ) {
-			foreach ( (array) $enclosures as $enclosure ) {
+			foreach ( $enclosures as $enclosure ) {
 				// Item thumbnail.
-				$thumbnail = $enclosure->get_thumbnail();
-				$medium    = $enclosure->get_medium();
+				$single_thumbnail = $enclosure->get_thumbnail();
+				$medium           = $enclosure->get_medium();
+
 				if ( in_array( $medium, array( 'video' ), true ) ) {
 					break;
 				}
-				if ( $thumbnail ) {
-					$the_thumbnail = $thumbnail;
+
+				if ( $single_thumbnail && $this->is_image_url( $single_thumbnail ) ) {
+					$the_thumbnail = $single_thumbnail;
 				}
-				if ( isset( $enclosure->thumbnails ) ) {
-					foreach ( (array) $enclosure->thumbnails as $thumbnail ) {
-						$the_thumbnail = $thumbnail;
+
+				$thumbnails = $enclosure->get_thumbnails();
+				if ( ! empty( $thumbnails ) ) {
+					foreach ( $thumbnails as $enclosure_thumbnail ) {
+						if ( ! $this->is_image_url( $enclosure_thumbnail ) ) {
+							continue;
+						}
+						$the_thumbnail = $enclosure_thumbnail;
 					}
 				}
-				$thumbnail = $enclosure->embed();
-				if ( $thumbnail ) {
+
+				$embedded_thumbnail = $enclosure->embed();
+				if ( $embedded_thumbnail ) {
 					$pattern = '/https?:\/\/.*\.(?:jpg|JPG|jpeg|JPEG|jpe|JPE|gif|GIF|png|PNG)/i';
-					if ( preg_match( $pattern, $thumbnail, $matches ) ) {
+					if ( preg_match( $pattern, $embedded_thumbnail, $matches ) ) {
 						$the_thumbnail = $matches[0];
 					}
 				}
-				foreach ( (array) $enclosure->get_link() as $thumbnail ) {
-					$pattern = '/https?:\/\/.*\.(?:jpg|JPG|jpeg|JPEG|jpe|JPE|gif|GIF|png|PNG)/i';
-					$imgsrc  = $thumbnail;
-					if ( preg_match( $pattern, $imgsrc, $matches ) ) {
-						$the_thumbnail = $thumbnail;
-						break;
-					} elseif ( in_array( $enclosure->type, $image_mime_types, true ) ) {
-						$the_thumbnail = $thumbnail;
-						break;
-					}
+
+				$enclosure_link = $enclosure->get_link();
+				if ( $this->is_image_url( $enclosure_link ) ) {
+					$the_thumbnail = $enclosure_link;
 				}
 				// Break loop if thumbnail is found.
 				if ( ! empty( $the_thumbnail ) ) {

includes/util/feedzy-rss-feeds-conditions.php

@@ -240,7 +240,7 @@ public function is_condition_met( $condition, $value ): bool {
 	 *
 	 * @param bool                  $default_value The current return value.
 	 * @param array<string, string> $attrs The attributes of the feed.
-	 * @param array<string, string> $item The item to evaluate.
+	 * @param SimplePie\Item        $item The item to evaluate.
 	 * @param string                $feed_url The URL of the feed.
 	 * @param int                   $index The index of the item.
 	 *

phpstan-baseline.neon

@@ -1705,31 +1705,6 @@ parameters:
 			count: 2
 			path: includes/layouts/setup-wizard.php
 
-		-
-			message: "#^Cannot call method get_author\\(\\) on array\\<string, string\\>\\.$#"
-			count: 1
-			path: includes/util/feedzy-rss-feeds-conditions.php
-
-		-
-			message: "#^Cannot call method get_content\\(\\) on array\\<string, string\\>\\.$#"
-			count: 1
-			path: includes/util/feedzy-rss-feeds-conditions.php
-
-		-
-			message: "#^Cannot call method get_date\\(\\) on array\\<string, string\\>\\.$#"
-			count: 1
-			path: includes/util/feedzy-rss-feeds-conditions.php
-
-		-
-			message: "#^Cannot call method get_item_tags\\(\\) on array\\<string, string\\>\\.$#"
-			count: 1
-			path: includes/util/feedzy-rss-feeds-conditions.php
-
-		-
-			message: "#^Cannot call method get_title\\(\\) on array\\<string, string\\>\\.$#"
-			count: 1
-			path: includes/util/feedzy-rss-feeds-conditions.php
-
 		-
 			message: "#^Constant SIMPLEPIE_NAMESPACE_ATOM_10 not found\\.$#"
 			count: 1
@@ -1740,11 +1715,6 @@ parameters:
 			count: 1
 			path: includes/util/feedzy-rss-feeds-conditions.php
 
-		-
-			message: "#^Parameter \\#1 \\$item of method Feedzy_Rss_Feeds_Admin_Abstract\\:\\:feedzy_retrieve_image\\(\\) expects object, array\\<string, string\\> given\\.$#"
-			count: 1
-			path: includes/util/feedzy-rss-feeds-conditions.php
-
 		-
 			message: "#^Unreachable statement \\- code above always terminates\\.$#"
 			count: 1