chore: add unit test

Author: Soare-Robert-Daniel

includes/admin/feedzy-rss-feeds-log.php

@@ -490,15 +490,15 @@ private function tail_file( $lines = 50 ) {
 				}
 				$line = fgets( $handle );
 				if ( false !== $line ) {
-					$text[ $lines - $line_counter - 1 ] = $line;
+					$text[] = $line;
 				}
 				if ( $beginning ) {
 					break;
 				}
 			}
 			fclose( $handle );
-
-			return array_reverse( $text );
+		
+			return $text;
 		} catch ( Throwable $e ) {
 			return new WP_Error( 'error_reading_log_file', $e->getMessage() );
 		}
@@ -529,7 +529,7 @@ function ( $line ) {
 			}
 		);
 
-		return array_slice( $lines, -$lines_count );
+		return array_reverse( array_slice( $lines, -$lines_count ) );
 	}
 
 	/**
@@ -846,7 +846,7 @@ public function try_accumulate_error_message( $message ) {
 			return;
 		}
 
-		if ( 200 >= count( $this->error_messages_accumulator ) ) {
+		if ( 200 <= count( $this->error_messages_accumulator ) ) {
 			return;
 		}
 

tests/test-image-import.php

@@ -23,16 +23,26 @@ public function test_image_import_url() {
 		$try_save_featured_image->setAccessible( true );
 
 		// Check that NON-IMAGE URL returns invalid
-		$import_errors = array();
 		$import_info = array();
-		$arguments = array( 'a random string', 0, 'Post Title', &$import_errors, &$import_info, array() );
+		$arguments = array( 'a random string', 0, 'Post Title', $import_info, array() );
 		$response = $try_save_featured_image->invokeArgs( $feedzy, $arguments );
 
 		$this->assertFalse( $response );
 
-		$this->assertTrue( count( $import_errors ) > 0 );
-		$this->assertEquals( 'Invalid Featured Image URL: a random string', $import_errors[0] );
-
+		// Check that error was logged for invalid URL
+		$logger = Feedzy_Rss_Feeds_Log::get_instance();
+		$recent_logs = $logger->get_recent_logs( 5, 'ERROR' );
+		$this->assertNotEmpty( $recent_logs );
+		
+		// Find the error log for invalid image URL
+		$found_error = false;
+		foreach ( $recent_logs as $log ) {
+			if ( strpos( $log['message'], 'Invalid image URL' ) !== false && strpos( $log['message'], 'a random string' ) !== false ) {
+				$found_error = true;
+				break;
+			}
+		}
+		$this->assertTrue( $found_error, 'Expected error log for invalid image URL not found' );
 
 		// For the next test, we will use a valid URL, but the image does not exist. We will check that the error is logged and is the expected one.
 		add_filter( 'themeisle_log_event', function( $product, $message, $type, $file, $line ) {
@@ -41,23 +51,19 @@ public function test_image_import_url() {
 			}
 		}, 10, 5 );
 
-		$import_errors = array();
 		$import_info = array();
-		$arguments = array( 'https://example.com/path_to_image/image.jpeg', 0, 'Post Title', &$import_errors, &$import_info, array() );
+		$arguments = array( 'https://example.com/path_to_image/image.jpeg', 0, 'Post Title', $import_info, array() );
 		$response = $try_save_featured_image->invokeArgs( $feedzy, $arguments );
 
-		// expected response is false because the image does not exist, but the URL is valid so no $import_errors should be set.
+		// expected response is false because the image does not exist, but the URL is valid so no errors should be logged for URL validation
 		$this->assertFalse( $response );
-		$this->assertTrue( empty( $import_errors ) );
 
-		$import_errors = array();
 		$import_info = array();
-		$arguments = array( 'https://example.com/path_to_image/image w space in name.jpeg', 0, 'Post Title', &$import_errors, &$import_info, array() );
+		$arguments = array( 'https://example.com/path_to_image/image w space in name.jpeg', 0, 'Post Title', $import_info, array() );
 		$response = $try_save_featured_image->invokeArgs( $feedzy, $arguments );
 
-		// expected response is false because the image does not exist, but the URL is valid so no $import_errors should be set.
+		// expected response is false because the image does not exist, but the URL is valid so no errors should be logged for URL validation
 		$this->assertFalse( $response );
-		$this->assertTrue( empty( $import_errors ) );
 	}
 
 	public function test_import_image_special_characters() {