Skip to content

Commit 7ff3582

Browse files
fixed suggestions
1 parent 71fb7e3 commit 7ff3582

File tree

3 files changed

+17
-19
lines changed

3 files changed

+17
-19
lines changed

includes/admin/feedzy-rss-feeds-admin.php

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2521,30 +2521,26 @@ public function add_black_friday_data( $configs ) {
25212521
*/
25222522
public function validate_feed() {
25232523
try {
2524-
if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['nonce'] ) ), FEEDZY_BASEFILE ) ) {
2525-
wp_send_json_error( array( 'message' => __( 'Security check failed.', 'feedzy-rss-feeds' ) ) );
2526-
return;
2527-
}
2524+
if ( ! isset( $_POST['nonce'] ) ||
2525+
! wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['nonce'] ) ), FEEDZY_BASEFILE ) ) {
2526+
wp_send_json_error( array( 'message' => __( 'Security check failed.', 'feedzy-rss-feeds' ) ) );
2527+
}
25282528

25292529
$feed_urls = isset($_POST['feed_url']) ? sanitize_text_field( wp_unslash( $_POST['feed_url'] ) ) : '';
25302530

25312531
if (empty($feed_urls)) {
25322532
wp_send_json_error(array('message' => __('Feed URL cannot be empty.', 'feedzy-rss-feeds')));
2533-
return;
25342533
}
25352534

25362535
$urls = array_map('trim', explode(',', $feed_urls));
25372536
$urls = array_filter($urls);
25382537

25392538
if (empty($urls)) {
25402539
wp_send_json_error(array('message' => __('No valid URLs provided.', 'feedzy-rss-feeds')));
2541-
return;
25422540
}
25432541

25442542
$results = array();
25452543

2546-
$cache = isset($_POST['cache']) ? sanitize_text_field( wp_unslash( $_POST['cache'] ) ) : '1_mins';
2547-
25482544
foreach ($urls as $feed_url) {
25492545
$feed_url = esc_url_raw($feed_url);
25502546

@@ -2557,7 +2553,7 @@ public function validate_feed() {
25572553
continue;
25582554
}
25592555

2560-
$feed = $this->fetch_feed(array($feed_url), $cache, array());
2556+
$feed = $this->fetch_feed(array($feed_url), '1_mins', array());
25612557

25622558
if ( is_wp_error($feed) ) {
25632559
$results[] = array(
@@ -2630,7 +2626,7 @@ public function validate_feed() {
26302626
wp_send_json_success(array(
26312627
'results' => $results
26322628
));
2633-
} catch (Exception $e) {
2629+
} catch (Throwable $e) {
26342630
wp_send_json_error(array(
26352631
/* translators: %s is the error message */
26362632
'message' => sprintf(__('An error occurred: %s', 'feedzy-rss-feeds'), $e->getMessage())

includes/views/css/import-metabox-edit.css

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -208,14 +208,13 @@ span.feedzy-spinner {
208208
padding: 12px 15px;
209209
border-radius: 4px;
210210
font-size: 14px;
211-
animation: slideIn 0.3s ease-out;
212211
position: relative;
213212
z-index: 10;
214-
display: flex;
215-
flex-direction: column;
213+
display: flex;
214+
flex-direction: column;
216215
align-items: flex-start;
217216
gap: 8px;
218-
border: 1px solid #5555559c;
217+
border: 1px solid #5555559c;
219218
}
220219

221220
.feedzy-wrap .fz-validation-message button {

includes/views/js/import-metabox-edit.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,6 @@
202202
function showMessage(message, autoDismiss = true) {
203203
const $container = $('.fz-validation-summary');
204204
if (!$container.length) {
205-
$('body').append('<div class="fz-validation-summary"></div>');
206205
return;
207206
}
208207

@@ -217,10 +216,14 @@
217216
if (autoDismiss) {
218217
$message.delay(5000).fadeOut(300, () => $message.remove());
219218
} else {
220-
$message.append(
221-
'<button type="button" class="button button-primary">✕</button>'
222-
);
223-
$message.find('button').on('click', function (e) {
219+
const $closeButton = $('<button>', {
220+
type: 'button',
221+
class: 'button button-primary',
222+
text: '✕'
223+
});
224+
225+
$message.append($closeButton);
226+
$closeButton.on('click', function (e) {
224227
e.preventDefault();
225228
$(this)
226229
.parent()

0 commit comments

Comments
 (0)