Skip to content

Commit af6df21

Browse files
feat: improve build process (#1039)
* feat: improve build process * fix: fix script path
1 parent 67538f0 commit af6df21

File tree

11 files changed

+302
-96
lines changed

11 files changed

+302
-96
lines changed

.distignore

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@ composer.lock
1818
package-lock.json
1919
key.enc
2020
js/FeedzyBlock
21-
js/Onboarding/import-onboarding.js
22-
js/ActionPopup/action-popup.js
23-
js/ActionPopup/Actions.js
24-
js/ActionPopup/SortableItem.js
21+
js/Onboarding/
22+
js/ActionPopup/
23+
js/FeedBack/
2524
webpack.config.js
2625
dist
2726
cypress
@@ -39,5 +38,3 @@ docker-compose.travis.yml
3938
.nvmrc
4039
.releaserc.yml
4140
docker-compose.ci.yml
42-
FeedBack/feedback.js
43-
FeedBack/feedback-form.js

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ cypress/fixtures
1212
cypress.env.json
1313
.phpunit.result.cache
1414
js/build
15+
/build
1516
artifacts

includes/admin/feedzy-rss-feeds-admin.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ public function enqueue_styles_admin() {
197197
$upsell_screens = array( 'feedzy-rss_page_feedzy-settings', 'feedzy-rss_page_feedzy-admin-menu-pro-upsell' );
198198
if ( 'feedzy_imports' === $screen->post_type && 'edit' !== $screen->base ) {
199199

200-
$asset_file = include FEEDZY_ABSPATH . '/js/build/action-popup.asset.php';
201-
wp_enqueue_script( $this->plugin_name . '_action_popup', FEEDZY_ABSURL . 'js/build/action-popup.js', array_merge( $asset_file['dependencies'], array( 'wp-editor', 'wp-api' ) ), $asset_file['version'], true );
200+
$asset_file = include FEEDZY_ABSPATH . '/build/action-popup/index.asset.php';
201+
wp_enqueue_script( $this->plugin_name . '_action_popup', FEEDZY_ABSURL . 'build/action-popup/index.js', array_merge( $asset_file['dependencies'], array( 'wp-editor', 'wp-api' ) ), $asset_file['version'], true );
202202

203203
wp_localize_script(
204204
$this->plugin_name . '_action_popup',
@@ -217,8 +217,8 @@ public function enqueue_styles_admin() {
217217
$this->register_survey();
218218
}
219219
if ( ! defined( 'TI_CYPRESS_TESTING' ) && ( 'edit' !== $screen->base && 'feedzy_imports' === $screen->post_type && feedzy_show_import_tour() ) ) {
220-
$asset_file = include FEEDZY_ABSPATH . '/js/build/import-onboarding.asset.php';
221-
wp_enqueue_script( $this->plugin_name . '_on_boarding', FEEDZY_ABSURL . 'js/build/import-onboarding.js', array_merge( $asset_file['dependencies'], array( 'wp-editor', 'wp-api' ) ), $asset_file['version'], true );
220+
$asset_file = include FEEDZY_ABSPATH . '/build/onboarding/index.asset.php';
221+
wp_enqueue_script( $this->plugin_name . '_on_boarding', FEEDZY_ABSURL . 'build/onboarding/index.js', array_merge( $asset_file['dependencies'], array( 'wp-editor', 'wp-api' ) ), $asset_file['version'], true );
222222
wp_set_script_translations( $this->plugin_name . '_on_boarding', 'feedzy-rss-feeds' );
223223
}
224224

@@ -231,8 +231,8 @@ public function enqueue_styles_admin() {
231231

232232
$this->register_survey();
233233

234-
$asset_file = include FEEDZY_ABSPATH . '/js/build/feedback.asset.php';
235-
wp_enqueue_script( $this->plugin_name . '_feedback', FEEDZY_ABSURL . 'js/build/feedback.js', array_merge( $asset_file['dependencies'], array( 'wp-editor', 'wp-api', 'lodash' ) ), $asset_file['version'], true );
234+
$asset_file = include FEEDZY_ABSPATH . '/build/feedback/index.asset.php';
235+
wp_enqueue_script( $this->plugin_name . '_feedback', FEEDZY_ABSURL . 'build/feedback/index.js', array_merge( $asset_file['dependencies'], array( 'wp-editor', 'wp-api', 'lodash' ) ), $asset_file['version'], true );
236236
wp_enqueue_style( 'wp-block-editor' );
237237

238238
wp_localize_script(

includes/gutenberg/feedzy-rss-feeds-gutenberg-block.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ private function __construct() {
5151
*/
5252
public function feedzy_gutenberg_scripts() {
5353
// Dependent WordPress core libraries.
54-
$asset_file = include FEEDZY_ABSPATH . '/js/build/block.asset.php';
54+
$asset_file = include FEEDZY_ABSPATH . '/build/block/index.asset.php';
5555
$depends = array_merge( $asset_file['dependencies'], array( 'wp-i18n', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-editor', 'wp-api', 'lodash', 'wp-hooks', 'jquery-ui-autocomplete' ) );
5656

5757
// Remove "wp-editor" script for widget block.
@@ -63,7 +63,7 @@ public function feedzy_gutenberg_scripts() {
6363
}
6464

6565
// Enqueue the bundled block JS file
66-
wp_enqueue_script( 'feedzy-gutenberg-block-js', FEEDZY_ABSURL . 'js/build/block.js', $depends, $asset_file['version'], true );
66+
wp_enqueue_script( 'feedzy-gutenberg-block-js', FEEDZY_ABSURL . 'build/block/index.js', $depends, $asset_file['version'], true );
6767

6868
wp_set_script_translations( 'feedzy-gutenberg-block-js', 'feedzy-rss-feeds' );
6969

@@ -80,7 +80,7 @@ public function feedzy_gutenberg_scripts() {
8080

8181
// Enqueue editor block styles
8282
wp_enqueue_style( 'feedzy-block-css', FEEDZY_ABSURL . 'css/feedzy-rss-feeds.css', array(), $this->version );
83-
wp_enqueue_style( 'feedzy-gutenberg-block-css', FEEDZY_ABSURL . 'js/build/style-block.css', array(), $this->version );
83+
wp_enqueue_style( 'feedzy-gutenberg-block-css', FEEDZY_ABSURL . 'build/block/style-index.css', array(), $this->version );
8484
}
8585

8686
/**
File renamed without changes.
File renamed without changes.

js/FeedzyBlock/block.js renamed to js/FeedzyBlock/index.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Block dependencies
55
*/
66
import './style.scss';
7-
import blockAttributes from './attributes';
7+
import blockAttributes from './attributes.js';
88
import Editor from './Editor.js';
99

1010
/**
@@ -17,22 +17,22 @@ const { registerBlockType } = wp.blocks;
1717
/**
1818
* Register block
1919
*/
20-
export default registerBlockType( 'feedzy-rss-feeds/feedzy-block', {
21-
title: __( 'Feedzy RSS Feeds', 'feedzy-rss-feeds' ),
20+
export default registerBlockType('feedzy-rss-feeds/feedzy-block', {
21+
title: __('Feedzy RSS Feeds', 'feedzy-rss-feeds'),
2222
category: 'common',
2323
icon: 'rss',
2424
keywords: [
25-
__( 'Feedzy RSS Feeds', 'feedzy-rss-feeds' ),
26-
__( 'RSS', 'feedzy-rss-feeds' ),
27-
__( 'Feeds', 'feedzy-rss-feeds' ),
25+
__('Feedzy RSS Feeds', 'feedzy-rss-feeds'),
26+
__('RSS', 'feedzy-rss-feeds'),
27+
__('Feeds', 'feedzy-rss-feeds'),
2828
],
2929
supports: {
3030
html: false,
3131
},
3232
attributes: blockAttributes,
3333
edit: Editor,
3434
save() {
35-
// Rendering in PHP
36-
return null;
35+
// Rendering in PHP
36+
return null;
3737
},
3838
});
File renamed without changes.

0 commit comments

Comments
 (0)