Single Product gallery changed layout with the last PRF release

[rodica-andronache]

Description

Not sure if this was something wanted or not. I couldn't see something about it mentioned in the changelog.

After the PRF release, in the free version, the layout of the gallery from single product pages changed. Before the release, images were at the bottom of the main image, now they are in the left side, with a slider. In Neve Pro there is an option to change the layout, but in free, this is not possible.

Step-by-step reproduction instructions

Before the release

After the release

Screenshots, screen recording, code snippet or Help Scout ticket

https://wordpress.org/support/topic/product-images-4-1-4-4-2-1/
https://secure.helpscout.net/conversation/3155822011/478548

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

[vytisbulkevicius]

@girishpanchal30 @poonam279 it was a misunderstanding of what this change was suppose to bring:
https://github.com/Codeinwp/neve-pro-addon/issues/2508

The default setting shouldn't have been changed for Neve free theme, it should remain as it was.

The feature created was suppose to change the photos on mobile layout, so on Neve PRO the change made for the gallery layout:

Should keep controlling the desktop layout but photos on mobile remain horizontal.

[girishpanchal30]

@vytisbulkevicius Just to confirm, we are adding an option to control the gallery layout on desktop, while on mobile it should remain horizontal. So do we need to revert the previously made changes?

[vytisbulkevicius]

@girishpanchal30, yes you are correct.

[girishpanchal30]

@vytisbulkevicius @rodica-andronache, I have added an option for gallery layout with this PR https://github.com/Codeinwp/neve-pro-addon/pull/3128. And revert the previously made changes with this PR #4468

[rodica-andronache]

@vytisbulkevicius can you please try this? For me it's not working, and I'm wondering if I understood this properly or not

[vytisbulkevicius]

@girishpanchal30,
So it looks close to correct since we reverted the setting for Neve Free theme to what was before and images are listed horizontally.

Now with Neve PRO settings the layouts also work and for desktop it works as expected - if I select horizontal images are listed horizontally on both desktop and mobile.

The problem is that we also respect the "Vertical" setting, as we discussed above:

Should keep controlling the desktop layout but photos on mobile remain horizontal.

And you also confirmed it:

while on mobile it should remain horizontal. So do we need to revert the previously made changes?

In my testing on mobile I see photos displayed vertically:

When gallery layout is left:

And we agreed that this setting should only be respected on desktop and ignored on mobile where images should remain horizontal no matter the setting.

Let me know if I'm missing something, thanks

[girishpanchal30]

@vytisbulkevicius I have tested it, and it works as expected on the mobile layout. Could you please provide your instance details so I can check further?

[vytisbulkevicius]

@girishpanchal30,

Here is PDP:
https://rightfulrobin.s6-tastewp.com/product/organic-dried-dog-food/

Mobile view:

Credentials:

Admin area URL: https://rightfulrobin.s6-tastewp.com/wp-admin
Username: bvytis
Password: UuviDCa2sso

[girishpanchal30]

@vytisbulkevicius The URL you provided redirects to the TasteWP login page. Could you please share the correct admin URL?

[vytisbulkevicius]

@girishpanchal30,

PDP: https://wraptoad.s2-tastewp.com/product/organic-dried-dog-food/

Credentials:

Admin area URL: https://wraptoad.s2-tastewp.com/wp-admin
Username: bvytis
Password: RJvk2crFftc

[girishpanchal30]

@vytisbulkevicius I have fixed it with the latest commit. Please check it and let me know if any changes are needed.