Extraneous Quotation Mark in Image URL in v4.0.0

[wags1128]

Description

The image URL generated by Optimole in v4.0.0 in conjunction with the Metaslider-Pro plugin contains an extraneous quotation mark as shown in the example below. The quotation mark precedes "decoding". Firefox tolerates this but flags it when you view source. This problem did not exist in v3.14.1.

-scaled.jpg" " decoding="async" width="2560" height="1707"

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

[selul]

Hi @wags1128,

Thanks a lot for reporting, will look into this asap and roll out a fix.

[selul]

Hi @wags1128,
I’ve tried to replicate the issue on a standard install, but I wasn’t able to reproduce it on my end.

Would you happen to have a staging site you could share access to? That would really help us troubleshoot and better understand what might be going wrong.

If you’re able to, please get in touch with us via this contact form and include the relevant details.

Appreciate your help — looking forward to resolving this for you!

[wags1128]

Since this problem only occurs when using Optimole v4.0.0 along with Metaslider Pro (and only on the first slide), I will investigate further on my own. If I fail to find the cause, I will grant access to a development site. If I succeed, I will share my findings with you. I will need a few days but I will get back to you. Best regards.

…

On Wed, Apr 16, 2025 at 5:36 AM Marius Cristea ***@***.***> wrote: Hi @wags1128 <https://github.com/wags1128>, I’ve tried to replicate the issue on a standard install, but I wasn’t able to reproduce it on my end. Would you happen to have a staging site you could share access to? That would really help us troubleshoot and better understand what might be going wrong. If you’re able to, please get in touch with us via this contact form <https://optimole.com/contact> and include the relevant details. Appreciate your help — looking forward to resolving this for you! — Reply to this email directly, view it on GitHub <#920 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5BF6ODVVBH55SHGVQIKE32ZYQALAVCNFSM6AAAAAB3GCXQYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBYHE4DIMBTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***> *selul* left a comment (Codeinwp/optimole-wp#920) <#920 (comment)> Hi @wags1128 <https://github.com/wags1128>, I’ve tried to replicate the issue on a standard install, but I wasn’t able to reproduce it on my end. Would you happen to have a staging site you could share access to? That would really help us troubleshoot and better understand what might be going wrong. If you’re able to, please get in touch with us via this contact form <https://optimole.com/contact> and include the relevant details. Appreciate your help — looking forward to resolving this for you! — Reply to this email directly, view it on GitHub <#920 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5BF6ODVVBH55SHGVQIKE32ZYQALAVCNFSM6AAAAAB3GCXQYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBYHE4DIMBTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[wags1128]

The cause of this problem may be found in the lazyload_tag_replace function in lazyload_replacer.php in v4.0.0. A new Regular Expression attempts to remove fetchpriority="high" but fails to remove the final quotation mark.

Before regexp: <img fetchpriority="high" decoding="async" width="2560" height="1707"
After regexp: <img" decoding="async" width="2560" height="1707"

Note the quotation mark immediately after '<img"'. That quotation mark will move as the "img" tag is undergoes additional modifications.

The Regular Expression that needs to change is as follows:

$new_tag = preg_replace( '/\s+fetchpriority=(high|['"][^\'"]high[^\'"])(?=['"\s>]|$)/i', '', $new_tag );

My Regular Expression skills are not good enough so I added the following hack right after the preg_replace.

if ( str_starts_with( $new_tag, '<img"' ) ) {
    $new_tag = str_replace('<img" ', '<img ', $new_tag);
}

To reproduce this problem the Lazyload setting should be: "Skip Lazy Loading for First 0 Images".

Should you have any questions, please reach out.

I hope this helps. Have a great day!

[selul]

@wags1128 Thank you for much for the detail report. I was able to replicate it. Will roll out a fix right away.

[selul]

fixed it in 4.0.1 version.

Thanks a lot for your help, appreciate it!