Skip to content

Commit 00621a5

Browse files
Merge pull request #699 from contactashish13/issue-268-pro
Issues editing Pie charts in the Gutenberg block
2 parents 7bc6337 + de0e966 commit 00621a5

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

classes/Visualizer/Gutenberg/build/block.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/src/Editor.js

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -341,19 +341,30 @@ class Editor extends Component {
341341
if ( 'pie' === type ) {
342342
map = chartData;
343343
fieldName = 'slices';
344-
}
344+
345+
// pie charts are finicky about a number being a number
346+
// and editing a number makes it a string
347+
// so let's convert it back into a number.
348+
chartData.map( ( i, index ) => {
349+
switch ( series[1].type ) {
350+
case 'number':
351+
i[1] = parseFloat( i[1]);
352+
break;
353+
}
354+
});
355+
}
345356

346357
map.map( ( i, index ) => {
347358
if ( 'pie' !== type && 0 === index ) {
348-
return;
359+
return;
349360
}
350361

351362
const seriesIndex = 'pie' !== type ? index - 1 : index;
352363

353364
if ( settings[fieldName][seriesIndex] === undefined ) {
354-
settings[fieldName][seriesIndex] = {};
365+
settings[fieldName][seriesIndex] = {};
355366
settings[fieldName][seriesIndex].temp = 1;
356-
}
367+
}
357368
});
358369

359370
settings[fieldName] = settings[fieldName].filter( ( i, index ) => {

0 commit comments

Comments
 (0)