phpunit more tests #142

Author: contactashish13

classes/Visualizer/Module/Chart.php

@@ -250,7 +250,7 @@ public function renderChartPages() {
 		}
 
 		// dispatch pages
-		$this->_chart = $chart;
+		$this->_chart = get_post( $chart_id );
 		switch ( isset( $_GET['tab'] ) ? $_GET['tab'] : '' ) {
 			case 'settings':
 				// changed by Ash/Upwork
@@ -552,7 +552,7 @@ public function exportData() {
 		$chart_id = $success = false;
 		$capable = current_user_can( 'edit_posts' );
 		if ( $capable ) {
-			$chart_id = filter_input( INPUT_GET, 'chart', FILTER_VALIDATE_INT, array( 'options' => array( 'min_range' => 1 ) ) );
+			$chart_id = isset( $_GET['chart'] ) ? filter_var( $_GET['chart'], FILTER_VALIDATE_INT, array( 'options' => array( 'min_range' => 1 ) ) ) : '';
 			if ( $chart_id ) {
 				$chart = get_post( $chart_id );
 				$success = $chart && $chart->post_type == Visualizer_Plugin::CPT_VISUALIZER;
@@ -561,7 +561,7 @@ public function exportData() {
 
 		if ( $success ) {
 			$settings   = get_post_meta( $chart_id, Visualizer_Plugin::CF_SETTINGS, true );
-			$filename   = $settings['title'];
+			$filename   = isset( $settings['title'] ) ? $settings['title'] : '';
 			if ( empty( $filename ) ) {
 				$filename   = 'export.csv';
 			} else {
@@ -620,6 +620,6 @@ public function exportData() {
 			));
 		}// End if().
 
-		exit;
+		wp_die();
 	}
 }

languages/visualizer.pot

@@ -4,7 +4,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Visualizer: Charts and Graphs Lite 2.0.0\n"
 "Report-Msgid-Bugs-To: https://github.com/Codeinwp/visualizer/issues\n"
-"POT-Creation-Date: 2017-03-15 13:57:55+00:00\n"
+"POT-Creation-Date: 2017-03-16 05:02:53+00:00\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=utf-8\n"
 "Content-Transfer-Encoding: 8bit\n"

tests/test-export.php

@@ -0,0 +1,90 @@
+<?php
+
+/**
+ * Test class for the exporting features.
+ *
+ * @package     Visualizer
+ * @subpackage  Tests
+ * @copyright   Copyright (c) 2017, Marius Cristea
+ * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+ * @since       2.0.0
+ */
+class Test_Export extends WP_Ajax_UnitTestCase {
+
+	/**
+	 * The chart id of the chart created
+	 *
+	 * @since 2.0.0
+	 *
+	 * @access private
+	 * @var int
+	 */
+	private $chart;
+
+	/**
+	 * Create a chart
+	 *
+	 * @since 2.0.0
+	 *
+	 * @access private
+	 */
+	private function create_chart() {
+		$this->_setRole( 'administrator' );
+
+		$_GET   = array(
+			'library'       => 'yes',
+			'tab'           => 'visualizer',
+		);
+
+		// swallow the output
+		ob_start();
+		try {
+			$this->_handleAjax( 'visualizer-create-chart' );
+		} catch ( WPAjaxDieContinueException $e ) {
+			// We expected this, do nothing.
+		} catch ( WPAjaxDieStopException $ee ) {
+			// We expected this, do nothing.
+		}
+		ob_end_clean();
+
+		$query          = new WP_Query(array(
+			'post_type'     => Visualizer_Plugin::CPT_VISUALIZER,
+			'post_status'   => 'auto-draft',
+			'numberposts'   => 1,
+			'fields'        => 'ids',
+		));
+		$this->chart    = $query->posts[0];
+	}
+
+	/**
+	 * Testing export
+	 *
+	 * @access public
+	 */
+	public function test_download_export() {
+		$this->create_chart();
+		$this->_setRole( 'administrator' );
+
+		$_GET  = array(
+			'security'      => wp_create_nonce( Visualizer_Plugin::ACTION_EXPORT_DATA . Visualizer_Plugin::VERSION ),
+			'chart'         => $this->chart,
+		);
+
+		// swallow the output
+		ob_start();
+		try {
+			$this->_handleAjax( 'visualizer-export-data' );
+		} catch ( WPAjaxDieContinueException  $e ) {
+			// We expected this, do nothing.
+		} catch ( WPAjaxDieStopException $ee) {
+			// We expected this, do nothing.
+		}
+		ob_end_clean();
+
+		$response = json_decode( $this->_last_response );
+		$this->assertInternalType( 'object', $response );
+		$this->assertObjectHasAttribute( 'success', $response );
+		$this->assertObjectHasAttribute( 'data', $response );
+		$this->assertTrue( $response->success );
+	}
+}