Skip to content

Commit 124fae4

Browse files
Merge pull request #1092 from Codeinwp/fix/classic-plugin
Fix Google chart rendering condition for Classic Plugin
2 parents 8b8336c + 0d23059 commit 124fae4

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

js/media/view.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
chart.settings = model.get('settings');
5858
chart.settings.width = self.options.width;
5959
chart.settings.height = self.options.height;
60-
$('#' + self.id).append(model.get('css'));
60+
$('#' + self.id).parent().append(model.get('css'));
6161

6262
$('body').trigger('visualizer:render:specificchart:start', {id: self.id, chart: chart, v: {page_type: 'post'}} );
6363
}

js/render-google.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,12 @@ var isResizeRequest = false;
5050
function renderSpecificChart(id, chart) {
5151
var render, container, series, data, table, settings, i, j, row, date, axis, property, format, formatter;
5252

53-
if ( ! window.isResizeRequest && ( $('#' + id).hasClass('visualizer-chart-loaded') || ( 'canvas' !== id && $('#' + id).children( ':not(.loader)' ).length > 0 ) ) ) {
53+
if( chart.library !== 'google' ) {
5454
return;
5555
}
56-
57-
if(chart.library !== 'google'){
56+
57+
// Bail if the chart is already rendered or is being rendered.
58+
if ( ! window.isResizeRequest && ( $('#' + id).hasClass('visualizer-chart-loaded') || ( 'canvas' !== id && $('#' + id).children( ':not(.loader, style)' ).length > 0 ) ) ) {
5859
return;
5960
}
6061
rendered_charts[id] = 'yes';

0 commit comments

Comments
 (0)