Skip to content

Commit 1faba37

Browse files
Merge pull request #508 from contactashish13/issue-507
Increase minimum requirement to PHP 5.6
2 parents 37f7524 + ebef46b commit 1faba37

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

.travis.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,12 @@ matrix:
88
- php: 7.1
99
- php: 7.0
1010
- php: '5.6'
11+
- name: Wraith
12+
php: '5.6'
1113
install: true
1214
before_script: chmod +x bin/wraith.sh
1315
env: TEST_SUITE=Wraith_Visual_Regression_Testing WRAITH_FAIL=5
1416
script: "./bin/wraith.sh"
15-
- php: 5.5
16-
env: WP_VERSION=5.1
17-
- php: 5.4
18-
env: WP_VERSION=5.1
19-
- php: 5.3
20-
env: WP_VERSION=5.1
21-
dist: precise
2217
allow_failures:
2318
- env: TEST_SUITE=Wraith_Visual_Regression_Testing WRAITH_FAIL=5
2419
branches:

classes/Visualizer/Render/Sidebar.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,12 @@ private static function is_excel_enabled() {
270270
include_once( $vendor_file );
271271
}
272272

273-
return class_exists( 'PhpOffice\PhpSpreadsheet\Spreadsheet' ) && extension_loaded( 'zip' ) && extension_loaded( 'xml' ) && extension_loaded( 'fileinfo' ) && version_compare( PHP_VERSION, '5.6.0', '>' );
273+
if ( version_compare( phpversion(), '5.6.0', '<' ) ) {
274+
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'PHP version %s not supported', phpversion() ), 'error', __FILE__, __LINE__ );
275+
return false;
276+
}
277+
278+
return class_exists( 'PhpOffice\PhpSpreadsheet\Spreadsheet' ) && extension_loaded( 'zip' ) && extension_loaded( 'xml' ) && extension_loaded( 'fileinfo' );
274279
}
275280

276281
/**

classes/Visualizer/Source.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,7 @@ public static final function get_date_formats_if_exists( $series, $data ) {
329329
*/
330330
private static final function determine_date_format( $value, $type ) {
331331
if ( version_compare( phpversion(), '5.3.0', '<' ) ) {
332+
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'PHP version %s not supported', phpversion() ), 'error', __FILE__, __LINE__ );
332333
return null;
333334
}
334335

readme.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
**Tags:** chart, charts, charting, graph, graphs, graphing, visualisation, visualise data, visualization, visualize data, HTML5, canvas, pie chart, line chart, bar chart, column chart, gauge chart, area chart, scatter chart, candlestick chart, geo chart, google visualization api, data tables, chartjs
44
**Requires at least:** 3.5
55
**Tested up to:** 5.2
6+
**Requires PHP:** 5.6
67
**Stable tag:** trunk
78
**License:** GPL v2.0 or later
89
**License URI:** http://www.opensource.org/licenses/gpl-license.php

readme.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Contributors: codeinwp,marius2012,marius_codeinwp,hardeepasrani,themeisle,Madal
33
Tags: chart, charts, charting, graph, graphs, graphing, visualisation, visualise data, visualization, visualize data, HTML5, canvas, pie chart, line chart, bar chart, column chart, gauge chart, area chart, scatter chart, candlestick chart, geo chart, google visualization api, data tables, chartjs
44
Requires at least: 3.5
55
Tested up to: 5.2
6+
Requires PHP: 5.6
67
Stable tag: trunk
78
License: GPL v2.0 or later
89
License URI: http://www.opensource.org/licenses/gpl-license.php

0 commit comments

Comments
 (0)