Skip to content

Commit 314edd7

Browse files
Having SCRIPT_DEBUG on causes issues in real time update of charts
1 parent 8f739a7 commit 314edd7

File tree

4 files changed

+13
-23
lines changed

4 files changed

+13
-23
lines changed

js/preview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
delete settings['height'];
1818

1919
v.charts.canvas.settings = settings;
20-
v.update();
20+
$('body').trigger('visualizer:render:currentchart:update', {visualizer: v});
2121
}, 1000);
2222
}
2323

js/render-chartjs.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -385,13 +385,6 @@
385385
}
386386
}
387387

388-
if(typeof visualizer !== 'undefined'){
389-
// called while updating the chart.
390-
visualizer.update = function(){
391-
renderChart('canvas', visualizer);
392-
};
393-
}
394-
395388
$('body').on('visualizer:render:chart:start', function(event, v){
396389
all_charts = v.charts;
397390
render(v);
@@ -407,6 +400,10 @@
407400
renderSpecificChart(v.id, v.chart, v.v);
408401
});
409402

403+
$('body').on('visualizer:render:currentchart:update', function(event, v){
404+
renderChart('canvas', v.visualizer);
405+
});
406+
410407
// front end actions
411408
$('body').on('visualizer:action:specificchart', function(event, v){
412409
switch(v.action){

js/render-datatables.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -263,13 +263,6 @@
263263
}
264264
}
265265

266-
if(typeof visualizer !== 'undefined'){
267-
// called while updating the chart.
268-
visualizer.update = function(){
269-
renderSpecificChart('canvas', all_charts['canvas'], visualizer);
270-
};
271-
}
272-
273266
$('body').on('visualizer:render:chart:start', function(event, v){
274267
all_charts = v.charts;
275268
render(v);
@@ -279,6 +272,10 @@
279272
renderSpecificChart(v.id, v.chart, v.v);
280273
});
281274

275+
$('body').on('visualizer:render:currentchart:update', function(event, v){
276+
renderSpecificChart('canvas', all_charts['canvas'], v.visualizer);
277+
});
278+
282279
// front end actions
283280
$('body').on('visualizer:action:specificchart', function(event, v){
284281
switch(v.action){

js/render-google.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -319,14 +319,6 @@ var __visualizer_chart_images = [];
319319
}
320320
}
321321

322-
if(typeof visualizer !== 'undefined'){
323-
// called while updating the chart.
324-
visualizer.update = function(){
325-
renderChart('canvas');
326-
};
327-
}
328-
329-
330322
var resizeTimeout;
331323

332324
$(document).ready(function() {
@@ -421,6 +413,10 @@ var __visualizer_chart_images = [];
421413
renderSpecificChart(v.id, v.chart);
422414
});
423415

416+
$('body').on('visualizer:render:currentchart:update', function(event, v){
417+
renderChart('canvas');
418+
});
419+
424420
// front end actions
425421
$('body').on('visualizer:action:specificchart', function(event, v){
426422
switch(v.action){

0 commit comments

Comments
 (0)