descriptive error messages for JSON

Author: contactashish13

classes/Visualizer/Module/Chart.php

@@ -131,7 +131,7 @@ public function getJsonRoots() {
 
 		$roots = $source->fetchRoots();
 		if ( empty( $roots ) ) {
-			wp_send_json_error();
+			wp_send_json_error( array( 'msg' => $source->get_error() ) );
 		}
 
 		wp_send_json_success( array( 'url' => $params['url'], 'roots' => $roots ) );
@@ -159,7 +159,7 @@ public function getJsonData() {
 
 		$data   = $source->parse();
 		if ( empty( $data ) ) {
-			wp_send_json_error();
+			wp_send_json_error( array( 'msg' => esc_html__( 'Unable to fetch data from the endpoint. Please try again.', 'visualizer' ) ) );
 		}
 
 		$data   = Visualizer_Render_Layout::show( 'editor-table', $data, $chart_id, 'viz-json-table', false, false );

classes/Visualizer/Render/Page/Data.php

@@ -182,10 +182,10 @@ class="visualizer-select">
 								</li>
 
 								<li class="viz-subsection">
-								<span class="viz-section-title visualizer_source_json"><?php _e( 'Import from JSON/REST', 'visualizer' ); ?>
+								<span class="viz-section-title visualizer_source_json"><?php _e( 'Import from JSON', 'visualizer' ); ?>
 									<span class="dashicons dashicons-lock"></span></span>
 									<div class="viz-section-items section-items">
-										<p class="viz-group-description"><?php _e( 'You can choose here to import/synchronize your chart data with a remote JSON/REST source. For more info check <a href="https://docs.themeisle.com/article/1052-how-to-generate-charts-from-json-data-rest-endpoints" target="_blank" >this</a> tutorial', 'visualizer' ); ?></p>
+										<p class="viz-group-description"><?php _e( 'You can choose here to import/synchronize your chart data with a remote JSON source. For more info check <a href="https://docs.themeisle.com/article/1052-how-to-generate-charts-from-json-data-rest-endpoints" target="_blank" >this</a> tutorial', 'visualizer' ); ?></p>
 										<form id="vz-import-json" action="<?php echo $upload_link; ?>" method="post" target="thehole" enctype="multipart/form-data">
 											<div class="remote-file-section">
 													<?php

classes/Visualizer/Source/Json.php

@@ -107,7 +107,12 @@ public function fetchRoots() {
 		if ( false !== $roots ) {
 			return $roots;
 		}
-		return $this->getRootElements( 'root', '', array(), $this->getJSON() );
+		$roots = $this->getRootElements( 'root', '', array(), $this->getJSON() );
+		if ( empty( $roots ) ) {
+			$this->_error = esc_html__( 'This does not appear to be a valid JSON feed. Please try again.', 'visualizer' );
+			return false;
+		}
+		return $roots;
 	}
 
 	/**

js/frame.js

@@ -390,7 +390,7 @@
                         $('#json-root-form').fadeIn('medium');
                         json_accordion_activate(1, true);
                     }else{
-                        alert(visualizer.l10n.json_error);
+                        alert(data.data.msg);
                     }
                 },
                 complete: function(){
@@ -435,7 +435,7 @@
                         json_accordion_activate(2, false);
                         $table.columns.adjust().draw();
                     }else{
-                        alert(visualizer.l10n.json_error);
+                        alert(data.data.msg);
                     }
                 },
                 complete: function(){