Skip to content

Commit 5450068

Browse files
Merge pull request #1052 from Codeinwp/bugfix/1051
Fixed onboarding chart import issue
2 parents 11c5b97 + 1b9863f commit 5450068

File tree

7 files changed

+19
-13
lines changed

7 files changed

+19
-13
lines changed

classes/Visualizer/Gutenberg/build/block.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/src/Components/ChartEditor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class ChartEditor extends Component {
8080

8181
<ButtonGroup>
8282
<Button
83-
isDefault
83+
variant="secondary"
8484
isLarge
8585
onClick={ this.props.toggleModal }
8686
>

classes/Visualizer/Gutenberg/src/Components/ChartSelect.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ class ChartSelect extends Component {
5656
}
5757

5858
render() {
59-
60-
let chartVersion = 'undefined' !== typeof google ? google.visualization.Version : 'current';
59+
let chartVersion = 'undefined' !== typeof google.visualization ? google.visualization.Version : 'current';
6160

6261
let chart, footer;
6362

classes/Visualizer/Gutenberg/src/Components/Import/SQLEditor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class SQLEditor extends Component {
9797
<div className="visualizer-db-query-actions">
9898
<Button
9999
isLarge
100-
isDefault
100+
variant="secondary"
101101
isBusy={ this.state.isLoading }
102102
onClick={ this.onSave }
103103
>

classes/Visualizer/Gutenberg/src/Components/Sidebar/SeriesSettings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ class SeriesSettings extends Component {
6262
.map( ( i, index ) => {
6363
i = parseInt( i ) + 1;
6464
let indexToFormat = parseInt( i );
65-
let label = series[i].label || '';
66-
let type = series[i].type || '';
65+
let label = 'object' === typeof series[i] ? series[i].label : '';
66+
let type = 'object' == typeof series[i] ? series[i].type : '';
6767
let timer = 0;
6868
if ( 'tabular' !== type ) {
6969
indexToFormat = index;

classes/Visualizer/Gutenberg/src/Editor.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ class Editor extends Component {
587587
<ButtonGroup>
588588

589589
<Button
590-
isDefault
590+
variant="secondary"
591591
isLarge
592592
onClick={ () => {
593593
let route;
@@ -608,7 +608,7 @@ class Editor extends Component {
608608

609609
{ false === this.state.isModified ?
610610
<Button
611-
isDefault
611+
variant="secondary"
612612
isLarge
613613
className="visualizer-bttn-done"
614614
onClick={ () => {

classes/Visualizer/Module/Wizard.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,12 +212,13 @@ private function setup_wizard_import_chart() {
212212
'message' => __( 'Something went wrong while importing the chart', 'visualizer' ),
213213
);
214214

215+
$data = $source->getData();
215216
$args = array(
216217
'post_type' => Visualizer_Plugin::CPT_VISUALIZER,
217218
'post_title' => 'Visualization',
218219
'post_author' => get_current_user_id(),
219220
'post_status' => 'publish',
220-
'post_content' => $source->getData(),
221+
'post_content' => $data,
221222
);
222223
$chart_id = wp_insert_post( $args );
223224

@@ -232,8 +233,10 @@ private function setup_wizard_import_chart() {
232233
update_post_meta( $chart_id, Visualizer_Plugin::CF_SERIES, $series );
233234
update_post_meta( $chart_id, Visualizer_Plugin::CF_CHART_LIBRARY, '' );
234235

236+
$data = maybe_unserialize( $data );
235237
$setting_series = array();
236-
foreach ( $series as $s ) {
238+
$setting_slices = array();
239+
foreach ( $data as $s ) {
237240
$setting_series[] = array(
238241
'visibleInLegend' => '',
239242
'lineWidth' => '',
@@ -243,6 +246,10 @@ private function setup_wizard_import_chart() {
243246
'color' => '',
244247
'role' => '',
245248
);
249+
$setting_slices[] = array(
250+
'offset' => 0,
251+
'color' => '',
252+
);
246253
}
247254
update_post_meta(
248255
$chart_id,
@@ -289,7 +296,7 @@ private function setup_wizard_import_chart() {
289296
),
290297
'focusTarget' => 'datum',
291298
'series' => $setting_series,
292-
'slices' => array(),
299+
'slices' => $setting_slices,
293300
'vAxis' => array(
294301
'title' => '',
295302
'textPosition' => '',

0 commit comments

Comments
 (0)