remove scrollCollapse and work only on scrollY

Author: contactashish13

classes/Visualizer/Render/Sidebar/Type/DataTable/DataTable.php

@@ -190,12 +190,16 @@ protected function _renderTableSettings() {
 
 				echo '<div class="viz-section-delimiter section-delimiter"></div>';
 
-				self::_renderCheckboxItem(
-					esc_html__( 'Scroll Collapse', 'visualizer' ),
-					'scrollCollapse_bool',
-					$this->scrollCollapse_bool,
-					'true',
-					esc_html__( 'Allow the table to reduce in height when a limited number of rows are shown', 'visualizer' )
+				self::_renderTextItem(
+					esc_html__( 'Table Height', 'visualizer' ),
+					'scrollY_int',
+					isset( $this->scrollY_int ) ? $this->scrollY_int : '',
+					esc_html__( 'Height of the table in pixels (the table will show a scrollbar).', 'visualizer' ),
+					'',
+					'number',
+					array(
+						'min' => 0,
+					)
 				);
 
 				echo '<div class="viz-section-delimiter section-delimiter"></div>';

js/render-datatables.js

@@ -52,10 +52,13 @@
             switch(v.page_type){
                 case 'post':
                 case 'library':
+                    // remove scrollY if its greater than what will fit in the box (along with the legend).
+                    if(parseInt(chart.settings['scrollY_int']) > 180){
+                        chart.settings['scrollY_int'];
+                    }
                     $.extend( settings, { 
                             scrollX: 150,
                             scrollY: 180,
-                            scrollCollapse: true
                     } );
                     break;
                 case 'frontend':