Skip to content

Commit 5f919f1

Browse files
omit left in legend position for bubble chart
1 parent b40b8a6 commit 5f919f1

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

classes/Visualizer/Gutenberg/build/block.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/src/Components/Sidebar/GeneralSettings.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ class GeneralSettings extends Component {
4646
positions.push({ label: __( 'Inside the chart' ), value: 'in' });
4747
}
4848

49+
if ( 'bubble' === type ) {
50+
positions = positions.filter( function( obj ) {
51+
return 'left' !== obj.value;
52+
});
53+
}
54+
4955
let titleHelp = __( 'Text to display above the chart.' );
5056
if ( 0 <= [ 'tabular', 'dataTable', 'gauge', 'geo', 'timeline' ].indexOf( type ) ) {
5157
titleHelp = __( 'Text to display in the back-end admin area' );
@@ -200,9 +206,11 @@ class GeneralSettings extends Component {
200206
if ( 'pie' !== type ) {
201207
let axis = 'left' === e ? 1 : 0;
202208

203-
Object.keys( settings.series ).map( i => {
204-
settings.series[i].targetAxisIndex = axis;
205-
});
209+
if ( settings.series ) {
210+
Object.keys( settings.series ).map( i => {
211+
settings.series[i].targetAxisIndex = axis;
212+
});
213+
}
206214
}
207215

208216
settings.legend.position = e;

classes/Visualizer/Render/Sidebar/Google.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ public function __construct( $data = array() ) {
7474

7575
if ( in_array( $chart_type, array( 'Bubble' ), true ) ) {
7676
unset( $this->_legendPositions['left'] );
77-
unset( $this->_legendPositions['right'] );
7877
}
7978

8079
$this->_alignments = array(

0 commit comments

Comments
 (0)