Skip to content

Commit 69ff7f5

Browse files
WIP: indexes do not get mangled
1 parent 17df9ec commit 69ff7f5

File tree

1 file changed

+24
-5
lines changed

1 file changed

+24
-5
lines changed

js/render-google.js

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,29 @@ var __visualizer_chart_images = [];
5555
settings['animation']['duration'] = parseInt(settings['animation']['duration']);
5656
}
5757

58+
// mark roles for series that have specified a role
59+
// and then remove them from future processing
60+
// and also adjust the indices of the series array so that
61+
// the ones with a role are deleted
62+
// e.g. if there are 6 columns (0-5) out of which 1, 3 and 5 are annotations
63+
// the final series will only include 0, 1, 2
64+
if (settings.series) {
65+
var adjusted_series = [];
66+
for (i = 0; i < settings.series.length; i++) {
67+
if (!series[i + 1] || typeof settings.series[i] === 'undefined') {
68+
continue;
69+
}
70+
if(typeof settings.series[i].role !== 'undefined'){
71+
table.setColumnProperty(i + 1, 'role', settings.series[i].role);
72+
if(settings.series[i].role === '') {
73+
adjusted_series.push(settings.series[i]);
74+
}
75+
}
76+
}
77+
settings.series = adjusted_series;
78+
}
79+
if(id.indexOf('1568') !== -1) console.log(series.length);
80+
5881
switch (chart.type) {
5982
case 'pie':
6083
if (settings.slices) {
@@ -204,12 +227,9 @@ var __visualizer_chart_images = [];
204227
break;
205228
default:
206229
for (i = 0; i < settings.series.length; i++) {
207-
if (!series[i + 1]) {
230+
if (!series[i + 1] || typeof settings.series[i] === 'undefined') {
208231
continue;
209232
}
210-
if(typeof settings.series[i].role !== 'undefined'){
211-
table.setColumnProperty(i + 1, 'role', settings.series[i].role);
212-
}
213233
format_data(id, table, series[i + 1].type, settings.series[i].format, i + 1);
214234
}
215235
break;
@@ -218,7 +238,6 @@ var __visualizer_chart_images = [];
218238
format_data(id, table, 'number', settings.format, 1);
219239
}
220240

221-
222241
if(settings.hAxis) {
223242
format_data(id, table, series[0].type, settings.hAxis.format, 0);
224243
}

0 commit comments

Comments
 (0)