Skip to content

Commit 70ec9f5

Browse files
Merge pull request #774 from contactashish13/issue-769
make offset a number field
2 parents 9446724 + 05f9fa1 commit 70ec9f5

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

classes/Visualizer/Gutenberg/build/block.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/src/Components/Sidebar/SlicesSettings.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ class SlicesSettings extends Component {
6868
settings.slices[i].offset = e;
6969
this.props.edit( settings );
7070
} }
71+
type="number"
72+
min="0"
73+
step="0.1"
7174
/>
7275

7376
<BaseControl

classes/Visualizer/Render/Sidebar/Type/GoogleCharts/Pie.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,11 @@ protected function _renderSlicesSettings() {
186186
self::_renderTextItem(
187187
esc_html__( 'Slice Offset', 'visualizer' ),
188188
'slices[' . $i . '][offset]',
189-
isset( $this->slices[ $i ]['offset'] ) ? $this->slices[ $i ]['offset'] : null,
189+
isset( $this->slices[ $i ]['offset'] ) && ! empty( $this->slices[ $i ]['offset'] ) ? $this->slices[ $i ]['offset'] : 0,
190190
esc_html__( "How far to separate the slice from the rest of the pie, from 0.0 (not at all) to 1.0 (the pie's radius).", 'visualizer' ),
191-
'0.0'
191+
'0.0',
192+
'number',
193+
array( 'step' => 0.1, 'min' => 0 )
192194
);
193195

194196
self::_renderColorPickerItem(

0 commit comments

Comments
 (0)