Skip to content

Commit 72cb2fa

Browse files
Merge pull request #271 from contactashish13/issue-269
Add title field to charts that do not support title field (only for u…
2 parents 73428b1 + 56af70f commit 72cb2fa

File tree

3 files changed

+35
-2
lines changed

3 files changed

+35
-2
lines changed

classes/Visualizer/Render/Sidebar/Type/Gauge.php

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,17 @@ protected function _toHTML() {
5555
*/
5656
protected function _renderGeneralSettings() {
5757
self::_renderGroupStart( esc_html__( 'General Settings', 'visualizer' ) );
58-
self::_renderSectionStart();
58+
59+
self::_renderSectionStart( esc_html__( 'Title', 'visualizer' ), false );
60+
self::_renderTextItem(
61+
esc_html__( 'Chart Title', 'visualizer' ),
62+
'title',
63+
$this->title,
64+
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
65+
);
66+
self::_renderSectionEnd();
67+
68+
self::_renderSectionStart( esc_html__( 'Gauge Settings', 'visualizer' ), false );
5969

6070
echo '<div class="viz-section-item">';
6171
echo '<a class="more-info" href="javascript:;">[?]</a>';

classes/Visualizer/Render/Sidebar/Type/Geo.php

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class Visualizer_Render_Sidebar_Type_Geo extends Visualizer_Render_Sidebar {
3838
* @access protected
3939
*/
4040
protected function _toHTML() {
41+
$this->_renderGeneralSettings();
4142
$this->_renderMapSettings();
4243
$this->_renderColorAxisSettings();
4344
$this->_renderSizeAxisSettings();
@@ -46,6 +47,26 @@ protected function _toHTML() {
4647
$this->_renderAdvancedSettings();
4748
}
4849

50+
/**
51+
* Renders general settings group.
52+
*
53+
* @since 1.0.0
54+
*
55+
* @access protected
56+
*/
57+
protected function _renderGeneralSettings() {
58+
self::_renderGroupStart( esc_html__( 'General Settings', 'visualizer' ) );
59+
self::_renderSectionStart( esc_html__( 'Title', 'visualizer' ), false );
60+
self::_renderTextItem(
61+
esc_html__( 'Chart Title', 'visualizer' ),
62+
'title',
63+
$this->title,
64+
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
65+
);
66+
self::_renderSectionEnd();
67+
self::_renderGroupEnd();
68+
}
69+
4970
/**
5071
* Renders map settings group.
5172
*

index.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ function visualizer_launch() {
8888
if ( is_admin() || defined( 'WP_TESTS_DOMAIN' ) ) {
8989
// set admin modules
9090
$plugin->setModule( Visualizer_Module_Admin::NAME );
91-
} else {
91+
}
92+
93+
if ( ! is_admin() || defined( 'WP_TESTS_DOMAIN' ) ) {
9294
// set frontend modules
9395
$plugin->setModule( Visualizer_Module_Frontend::NAME );
9496
}

0 commit comments

Comments
 (0)