Skip to content

Commit 85083e7

Browse files
authored
Merge pull request #823 from Codeinwp/bugfix/822
Fix undefined variable errors when use gutenberg blocks
2 parents 1dd9a04 + 88996df commit 85083e7

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

classes/Visualizer/Gutenberg/build/block.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/src/Components/Sidebar/SeriesSettings.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ class SeriesSettings extends Component {
6161
{ Object.keys( settings.series )
6262
.map( ( i, index ) => {
6363
let indexToFormat = parseInt( i );
64+
let label = series[i].label || '';
65+
let type = series[i].type || '';
6466

6567
if ( 'tabular' !== type ) {
6668
indexToFormat = index;
@@ -70,7 +72,7 @@ class SeriesSettings extends Component {
7072

7173
return (
7274
<PanelBody
73-
title={ series[i].label }
75+
title={ label }
7476
className="visualizer-inner-sections"
7577
initialOpen={ false }
7678
>
@@ -121,7 +123,7 @@ class SeriesSettings extends Component {
121123

122124
{ ( -1 >= [ 'candlestick' ].indexOf( type ) ) &&
123125

124-
( 'number' === series[i].type ) ? (
126+
( type && 'number' === type ) ? (
125127

126128
<Fragment>
127129

@@ -147,7 +149,7 @@ class SeriesSettings extends Component {
147149

148150
) :
149151

150-
( 0 <= [ 'date', 'datetime', 'timeofday' ].indexOf( series[i].type ) ) && (
152+
( 0 <= [ 'date', 'datetime', 'timeofday' ].indexOf( type ) ) && (
151153

152154
<Fragment>
153155

0 commit comments

Comments
 (0)