Merge pull request #518 from contactashish13/issue-517

contactashish13 · web-flow · commit 9e7e89e2ef21 · 2019-09-05T09:25:20.000+05:30
ChartJS: manual addition of data changes color for existing values
diff --git a/classes/Visualizer/Module/Utility.php b/classes/Visualizer/Module/Utility.php
@@ -187,13 +187,17 @@ private static function set_defaults_google( $chart, $post_status ) {
 	}
 
 	/**
-	 * Sets some defaults in the chart for ChartJS charts.
+	 * Sets some defaults in the chart for ChartJS charts. Only during first creation.
 	 *
 	 * @since 3.3.0
 	 *
 	 * @access private
 	 */
 	private static function set_defaults_chartjs( $chart, $post_status ) {
+		if ( $post_status !== 'auto-draft' ) {
+			return;
+		}
+
 		$type = get_post_meta( $chart->ID, Visualizer_Plugin::CF_CHART_TYPE, true );
 		$series = get_post_meta( $chart->ID, Visualizer_Plugin::CF_SERIES, true );
 		$settings = get_post_meta( $chart->ID, Visualizer_Plugin::CF_SETTINGS, true );

Original file line number	Diff line number	Diff line change
`@@ -187,13 +187,17 @@ private static function set_defaults_google( $chart, $post_status ) {`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`/**`
`190`		`- * Sets some defaults in the chart for ChartJS charts.`
	`190`	`+ * Sets some defaults in the chart for ChartJS charts. Only during first creation.`
`191`	`191`	`*`
`192`	`192`	`* @since 3.3.0`
`193`	`193`	`*`
`194`	`194`	`* @access private`
`195`	`195`	`*/`
`196`	`196`	`private static function set_defaults_chartjs( $chart, $post_status ) {`
	`197`	`+ if ( $post_status !== 'auto-draft' ) {`
	`198`	`+ return;`
	`199`	`+ }`
	`200`	`+`
`197`	`201`	`$type = get_post_meta( $chart->ID, Visualizer_Plugin::CF_CHART_TYPE, true );`
`198`	`202`	`$series = get_post_meta( $chart->ID, Visualizer_Plugin::CF_SERIES, true );`
`199`	`203`	`$settings = get_post_meta( $chart->ID, Visualizer_Plugin::CF_SETTINGS, true );`