Sanitize negative precision

https://github.com/Codeinwp/visualizer-pro/issues/256

Author: contactashish13

classes/Visualizer/Gutenberg/build/block.js

@@ -65,7 +65,7 @@ class DataTables extends Component {
 				title: i.label,
 				data: i.label,
 				type: type,
-				render: this.dataRenderer( data, type, index )
+				render: this.dataRenderer( type, index )
 			};
 		});
 
@@ -94,9 +94,9 @@ class DataTables extends Component {
 			pagingType: settings.pagingType,
 			ordering: 'false' === settings.ordering_bool ? false : true,
 			fixedHeader: 'true' === settings.fixedHeader_bool ? true : false,
-			scrollCollapse: this.props.chartsScreen && true || 'true' === settings.scrollCollapse_bool ? true : false,
+			scrollCollapse: !! this.props.chartsScreen || 'true' === settings.scrollCollapse_bool ? true : false,
 			scrollY: this.props.chartsScreen && 180 || ( 'true' === settings.scrollCollapse_bool && Number( settings.scrollY_int ) || false ),
-			responsive: this.props.chartsScreen && true || 'true' === settings.responsive_bool ? true : false,
+			responsive: !! this.props.chartsScreen || 'true' === settings.responsive_bool ? true : false,
 			searching: false,
 			select: false,
 			lengthChange: false,
@@ -105,48 +105,47 @@ class DataTables extends Component {
 		});
 	}
 
-	dataRenderer( data, type, index ) {
+	dataRenderer( type, index ) {
 		const settings = this.props.options;
 
-		if ( undefined === settings.series[index]) {
-			return data;
-		}
-
-		if ( 'date' === type || 'datetime' === type || 'timeofday' === type ) {
-			if ( settings.series[index].format && settings.series[index].format.from && settings.series[index].format.to ) {
-				return jQuery.fn.dataTable.render.moment( settings.series[index].format.from, settings.series[index].format.to );
-			}
-
-			return jQuery.fn.dataTable.render.moment( 'MM-DD-YYYY' );
-		}
-
-		if ( 'num' === type ) {
-			const parts = [ '', '', '', '', '' ];
-
-			if ( settings.series[index].format.thousands ) {
-				parts[0] = settings.series[index].format.thousands;
-			}
-
-			if ( settings.series[index].format.decimal ) {
-				parts[1] = settings.series[index].format.decimal;
-			}
-
-			if ( settings.series[index].format.precision ) {
-				parts[2] = settings.series[index].format.precision;
-			}
-
-			if ( settings.series[index].format.prefix ) {
-				parts[3] = settings.series[index].format.prefix;
-			}
-
-			if ( settings.series[index].format.suffix ) {
-				parts[4] = settings.series[index].format.suffix;
-			}
+        let renderer = null;
+		if ( 'undefined' === typeof settings.series[index] || 'undefined' === typeof settings.series[index].format ) {
+            return renderer;
+        }
+
+        switch ( type ) {
+            case 'date':
+            case 'datetime':
+            case 'timeofday':
+                if ( settings.series[index].format && settings.series[index].format.from && settings.series[index].format.to ) {
+                    renderer = jQuery.fn.dataTable.render.moment( settings.series[index].format.from, settings.series[index].format.to );
+                } else {
+                    renderer = jQuery.fn.dataTable.render.moment( 'MM-DD-YYYY' );
+                }
+                break;
+            case 'num':
+                const parts = [ '', '', '', '', '' ];
 
-			return jQuery.fn.dataTable.render.number( ...parts );
-		}
+                if ( settings.series[index].format.thousands ) {
+                    parts[0] = settings.series[index].format.thousands;
+                }
+                if ( settings.series[index].format.decimal ) {
+                    parts[1] = settings.series[index].format.decimal;
+                }
+                if ( settings.series[index].format.precision && '0' != settings.series[index].format.precision ) {
+                    parts[2] = settings.series[index].format.precision;
+                }
+                if ( settings.series[index].format.prefix ) {
+                    parts[3] = settings.series[index].format.prefix;
+                }
+                if ( settings.series[index].format.suffix ) {
+                    parts[4] = settings.series[index].format.suffix;
+                }
+                renderer = jQuery.fn.dataTable.render.number( ...parts );
+                break;
+        }
 
-		return data;
+		return renderer;
 	}
 
 	render() {

classes/Visualizer/Gutenberg/src/Components/DataTable.js

@@ -129,6 +129,7 @@ class ColumnSettings extends Component {
 											help={ __( 'Round values to how many decimal places?' ) }
 											value={ settings.series[i].format ? settings.series[i].format.precision : '' }
 											type="number"
+                                            min="0"
 											onChange={ e => {
 												if ( 100 < e ) {
 													return;

classes/Visualizer/Gutenberg/src/Components/Sidebar/ColumnSettings.js

@@ -442,7 +442,9 @@ protected function _renderFormatField( $index = 0 ) {
 					'series[' . $index . '][format][precision]',
 					isset( $this->series[ $index ]['format']['precision'] ) ? $this->series[ $index ]['format']['precision'] : '',
 					esc_html__( 'Round values to how many decimal places?', 'visualizer' ),
-					''
+					'',
+					'number',
+					array( 'min' => 0 )
 				);
 				self::_renderTextItem(
 					esc_html__( 'Prefix', 'visualizer' ),

classes/Visualizer/Render/Sidebar/Type/DataTable/Tabular.php

@@ -249,7 +249,7 @@
                 if(typeof series.format.decimal !== ''){
                     parts[1] = series.format.decimal;
                 }
-                if(typeof series.format.precision !== ''){
+                if(typeof series.format.precision !== '' && series.format.precision != '0'){
                     parts[2] = series.format.precision;
                 }
                 if(typeof series.format.prefix !== ''){