Skip to content

Commit bcc44ac

Browse files
register and use global function
1 parent 3d80637 commit bcc44ac

File tree

5 files changed

+13
-25
lines changed

5 files changed

+13
-25
lines changed

classes/Visualizer/Render/Page/Update.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ protected function _toHTML() {
5151
if ( $this->settings ) {
5252
echo 'win.visualizer.charts.canvas.settings = ', $this->settings, ';';
5353
}
54-
echo 'win.visualizer.update();';
54+
echo 'win.updateChartPreview();';
5555
echo '}';
5656

5757
do_action( 'visualizer_add_update_hook', $this->series, $this->data );

js/render-chartjs.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -385,13 +385,6 @@
385385
}
386386
}
387387

388-
if(typeof visualizer !== 'undefined'){
389-
// called while updating the chart.
390-
visualizer.update = function(){
391-
renderChart('canvas', visualizer);
392-
};
393-
}
394-
395388
$('body').on('visualizer:render:chart:start', function(event, v){
396389
all_charts = v.charts;
397390
render(v);
@@ -408,7 +401,8 @@
408401
});
409402

410403
$('body').on('visualizer:render:currentchart:update', function(event, v){
411-
renderChart('canvas', v.visualizer);
404+
var data = v || event.detail;
405+
renderChart('canvas', data.visualizer);
412406
});
413407

414408
// front end actions

js/render-datatables.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -278,13 +278,6 @@
278278
}
279279
}
280280

281-
if(typeof visualizer !== 'undefined'){
282-
// called while updating the chart.
283-
visualizer.update = function(){
284-
renderSpecificChart('canvas', all_charts['canvas'], visualizer);
285-
};
286-
}
287-
288281
$('body').on('visualizer:render:chart:start', function(event, v){
289282
all_charts = v.charts;
290283
render(v);
@@ -295,7 +288,8 @@
295288
});
296289

297290
$('body').on('visualizer:render:currentchart:update', function(event, v){
298-
renderSpecificChart('canvas', all_charts['canvas'], v.visualizer);
291+
var data = v || event.detail;
292+
renderSpecificChart('canvas', all_charts['canvas'], data.visualizer);
299293
});
300294

301295
// front end actions

js/render-facade.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@
8181
}
8282

8383
$(document).ready(function(){
84+
85+
// for updating the currently displayed chart (preview mode)
86+
window.updateChartPreview = function(){
87+
var event = new CustomEvent('visualizer:render:currentchart:update', {detail: {visualizer: visualizer}});
88+
document.body.dispatchEvent(event);
89+
};
90+
8491
// facade loads N times in the library (where N = the number of different chart libraries supported)
8592
// so all charts are also loaded N times
8693
// this will ensure that no matter how many times facade is loaded, it initializes all charts only once.
@@ -168,4 +175,4 @@
168175

169176
return $(this);
170177
};
171-
})(jQuery);
178+
})(jQuery);

js/render-google.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -319,13 +319,6 @@ var __visualizer_chart_images = [];
319319
}
320320
}
321321

322-
if(typeof visualizer !== 'undefined'){
323-
// called while updating the chart.
324-
visualizer.update = function(){
325-
renderChart('canvas');
326-
};
327-
}
328-
329322
var resizeTimeout;
330323

331324
$(document).ready(function() {

0 commit comments

Comments
 (0)