Skip to content

Commit c2019ac

Browse files
author
cristian-ungureanu
authored
Merge pull request #854 from Codeinwp/bugfix/850
Fix tooltip ordering issue in line chart
2 parents eaf3aa4 + 889fc73 commit c2019ac

File tree

4 files changed

+25
-6
lines changed

4 files changed

+25
-6
lines changed

classes/Visualizer/Gutenberg/build/block.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/src/Components/Sidebar/SeriesSettings.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class SeriesSettings extends Component {
6363
let indexToFormat = parseInt( i );
6464
let label = series[i].label || '';
6565
let type = series[i].type || '';
66-
66+
let timer = 0;
6767
if ( 'tabular' !== type ) {
6868
indexToFormat = index;
6969
}
@@ -105,6 +105,15 @@ class SeriesSettings extends Component {
105105
settings.series[index].lineWidth = e;
106106
this.props.edit( settings );
107107
} }
108+
onKeyUp={ e => {
109+
clearTimeout( timer );
110+
timer = setTimeout( () => {
111+
if ( '' != settings.series[index].lineWidth && 0 >= settings.series[index].lineWidth ) {
112+
settings.series[index].lineWidth = '0.1';
113+
this.props.edit( settings );
114+
}
115+
}, 700 );
116+
} }
108117
/>
109118

110119
<TextControl

classes/Visualizer/Render/Sidebar/Linear.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ protected function _renderSeries( $index ) {
257257
echo '<tr>';
258258
echo '<td class="viz-section-table-column">';
259259
$line_width = isset( $this->series[ $index ]['lineWidth'] ) ? $this->series[ $index ]['lineWidth'] : '';
260-
echo '<input type="text" name="series[', $index, '][lineWidth]" class="control-text" value="', esc_attr( $line_width ), '" placeholder="2">';
260+
echo '<input type="text" name="series[', $index, '][lineWidth]" class="control-text series-linewidth" value="', esc_attr( $line_width ), '" placeholder="2">';
261261
echo '</td>';
262262
echo '<td class="viz-section-table-column">';
263263
$point_size = isset( $this->series[ $index ]['pointSize'] ) ? $this->series[ $index ]['pointSize'] : '';

js/render-google.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,4 +549,14 @@ var __visualizer_chart_images = [];
549549
}
550550
});
551551

552+
var timer = 0;
553+
$( document ).on( 'input', '.series-linewidth', function() {
554+
var seriesLineWidth = $( this );
555+
clearTimeout( timer );
556+
timer = setTimeout( function() {
557+
if ( seriesLineWidth.val() != '' && seriesLineWidth.val() <= 0 ) {
558+
seriesLineWidth.val( '0.1' );
559+
}
560+
}, 700 );
561+
} );
552562
})(jQuery);

0 commit comments

Comments
 (0)