File tree Expand file tree Collapse file tree 2 files changed +7
-1
lines changed
classes/Visualizer/Gutenberg/src Expand file tree Collapse file tree 2 files changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -144,7 +144,7 @@ class Charts extends Component {
144
144
rows = { data [ 'visualizer-data' ] }
145
145
columns = { data [ 'visualizer-series' ] }
146
146
chartsScreen = { true }
147
- options = { filterCharts ( data [ 'visualizer-settings' ] ) }
147
+ options = { data [ 'visualizer-settings' ] }
148
148
/>
149
149
) : ( '' !== data [ 'visualizer-data-exploded' ] ? (
150
150
< Chart
Original file line number Diff line number Diff line change @@ -15,6 +15,12 @@ export const formatDate = ( data ) => {
15
15
} ;
16
16
17
17
// A fork of deep-compact package as it had some issues
18
+ // NOTE: This method is likely to create problems.
19
+ // Problem Scenario #1:
20
+ // - A table has 5 columns (series). Say the 1st column is Date and others are Numbers.
21
+ // - If the 1st columns format (series.format) is provided, DataTable.js gets 6 (0-5) series.
22
+ // - BUT if the 1st columns format (series.format) is empty, DataTable.js gets 5 (1-4) series.
23
+ // That is why when sending options to DataTable.js, filterChart method has not been used.
18
24
const notEmpty = value => {
19
25
let key ;
20
26
You can’t perform that action at this time.
0 commit comments