Skip to content

Commit f507750

Browse files
don't filter data
1 parent 6f1c1df commit f507750

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

classes/Visualizer/Gutenberg/src/Components/Charts.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ class Charts extends Component {
144144
rows={ data['visualizer-data'] }
145145
columns={ data['visualizer-series'] }
146146
chartsScreen={ true }
147-
options={ filterCharts( data['visualizer-settings']) }
147+
options={ data['visualizer-settings'] }
148148
/>
149149
) : ( '' !== data['visualizer-data-exploded'] ? (
150150
<Chart

classes/Visualizer/Gutenberg/src/utils.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ export const formatDate = ( data ) => {
1515
};
1616

1717
// A fork of deep-compact package as it had some issues
18+
// NOTE: This method is likely to create problems.
19+
// Problem Scenario #1:
20+
// - A table has 5 columns (series). Say the 1st column is Date and others are Numbers.
21+
// - If the 1st columns format (series.format) is provided, DataTable.js gets 6 (0-5) series.
22+
// - BUT if the 1st columns format (series.format) is empty, DataTable.js gets 5 (1-4) series.
23+
// That is why when sending options to DataTable.js, filterChart method has not been used.
1824
const notEmpty = value => {
1925
let key;
2026

0 commit comments

Comments
 (0)