release: fixes

- Fixed an issue where the max checked option was not enforcing the selection limit, allowing users to select more options than specified.
- Fixed an issue where conditional logic based on checkbox selections was not functioning, preventing fields from being displayed correctly based on user choices.

Author: selul

inc/woocommerce.php

@@ -228,21 +228,19 @@ function ppom_check_validation( $product_id, $post_data, $passed = true ) {
 			continue;
 		}
 
-		if ( ! isset( $field['required'] ) || 'on' !== $field['required'] ) {
-			continue;
-		}
-
-		$passed = apply_filters( 'ppom_before_fields_validation', $passed, $field, $post_data, $product_id );
-
 		if (
-			empty( $field['data_name'] ) &&
-			empty( $field['required'] ) &&
-			empty( $field['min_checked'] ) &&
-			empty( $field['max_checked'] )
+			empty( $field['data_name'] ) ||
+			(
+				( ! isset( $field['required'] ) || 'on' !== $field['required'] ) &&
+				empty( $field['min_checked'] ) &&
+				empty( $field['max_checked'] )
+			)
 		) {
 			continue;
 		}
 
+		$passed = apply_filters( 'ppom_before_fields_validation', $passed, $field, $post_data, $product_id );
+
 		$data_name = sanitize_key( $field['data_name'] );
 
 		$title = isset( $field['title'] ) ? $field['title'] : '';

js/admin/ppom-admin.js

@@ -1,16 +1,16 @@
 // @ts-check
 "use strict";
 
-const FIELD_COMPATIBLE_WITH_SELECT_OPTIONS = [ 'select', 'radio', 'switcher', 'image','conditional_meta'];
+const FIELD_COMPATIBLE_WITH_SELECT_OPTIONS = [ 'select', 'radio', 'switcher', 'image', 'conditional_meta' ];
 const OPERATOR_COMPARISON_VALUE_FIELD_TYPE = {
-    'select': FIELD_COMPATIBLE_WITH_SELECT_OPTIONS,
+    'select': [...FIELD_COMPATIBLE_WITH_SELECT_OPTIONS, 'checkbox'],
 }
 const COMPARISON_VALUE_CAN_USE_SELECT = [ 'is', 'not', 'greater than', 'less than' ];
 const HIDE_COMPARISON_INPUT_FIELD = ['any', 'empty', 'odd-number', 'even-number'];
 const FIELDS_COMPATIBLE_WITH_TEXT = [ 'text', 'textarea', 'date', 'email' ]
 const FIELDS_COMPATIBLE_WITH_NUMBERS = [ ...FIELD_COMPATIBLE_WITH_SELECT_OPTIONS, 'number' ];
 const OPERATORS_FIELD_COMPATIBILITY = {
-    'is': [...FIELD_COMPATIBLE_WITH_SELECT_OPTIONS, ...FIELDS_COMPATIBLE_WITH_TEXT, ...FIELDS_COMPATIBLE_WITH_NUMBERS, 'checkbox',],
+    'is': [...FIELD_COMPATIBLE_WITH_SELECT_OPTIONS, ...FIELDS_COMPATIBLE_WITH_TEXT, ...FIELDS_COMPATIBLE_WITH_NUMBERS, 'checkbox'],
     'not': [...FIELD_COMPATIBLE_WITH_SELECT_OPTIONS, ...FIELDS_COMPATIBLE_WITH_TEXT, ...FIELDS_COMPATIBLE_WITH_NUMBERS, 'checkbox'],
     'greater than': FIELDS_COMPATIBLE_WITH_NUMBERS,
     'less than': FIELDS_COMPATIBLE_WITH_NUMBERS,