refactor: add optional limit parameter to product meta count

Author: Soare-Robert-Daniel

classes/plugin.class.php

@@ -626,12 +626,16 @@ function get_product_meta_all() {
 	/**
 	 * Get the count of all the created PPOM Group fields.
 	 * 
+	 * @param int $limit Optional limit on number of results to count
 	 * @return int - The number of group fields in the database.
 	 */
-	public static function get_product_meta_count() {
+	public static function get_product_meta_count( $limit = null ) {
 		global $wpdb;
 
 		$qry = 'SELECT COUNT(*) FROM ' . $wpdb->prefix . PPOM_TABLE_META;
+		if ($limit !== null) {
+			$qry .= ' LIMIT ' . intval($limit);
+		}
 		$count = $wpdb->get_var($qry);
 
 		return intval($count);

classes/survey.class.php

@@ -14,6 +14,13 @@
 	 */
 	class PPOM_Survey {
 
+		/**
+		 * The maximum limit of created groups to count. Used in the duration of the cached value.
+		 *
+		 * @var int
+		 */
+		public const GROUPS_COUNT_LIMIT = 100;
+
 		/**
 		 * Reference to singleton insance.
 		 *
@@ -55,8 +62,8 @@ public function get_survey_metadata( $data, $page_slug ) {
 			$group_fields_count = get_transient( PPOM_GROUPS_COUNT_CACHE_KEY );
 
 			if ( false === $group_fields_count ) {
-				$group_fields_count = min( 100, NM_PersonalizedProduct::get_product_meta_count() );
-				set_transient( PPOM_GROUPS_COUNT_CACHE_KEY, $group_fields_count, 100 <= $group_fields_count ? WEEK_IN_SECONDS : 12 * HOUR_IN_SECONDS );
+				$group_fields_count = NM_PersonalizedProduct::get_product_meta_count( self::GROUPS_COUNT_LIMIT );
+				set_transient( PPOM_GROUPS_COUNT_CACHE_KEY, $group_fields_count, self::GROUPS_COUNT_LIMIT === $group_fields_count ? WEEK_IN_SECONDS : 12 * HOUR_IN_SECONDS );
 			}
 
 			$install_days_number = intval( ( time() - get_option( 'woocommerce_product_addon_install', time() ) ) / DAY_IN_SECONDS );