Skip to content

Commit 8dd555c

Browse files
committed
Miscellaneous fixes
- Fix list view and grid view data source fields not syncing to server. - Fix json serializing issue with where filters.
1 parent 0c3aeea commit 8dd555c

File tree

6 files changed

+13
-21
lines changed

6 files changed

+13
-21
lines changed

lib/src/api/models/action/load_from_cloud_storage_action.g.dart

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/api/nodes/grid_view_node.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class GridViewNode extends SinglePlaceholderNode
5656
bool useCloudDatabase = false,
5757
String? collectionPath,
5858
int? limit = 20,
59-
List<WhereQueryFilter>? whereOperations,
59+
List<WhereQueryFilter>? whereFilters,
6060
List<OrderByQueryFilter>? orderByFilters,
6161

6262
// [ScrollableMixin] properties.
@@ -70,9 +70,7 @@ class GridViewNode extends SinglePlaceholderNode
7070
}) : super(
7171
children: [],
7272
allowedTypes: [],
73-
deniedTypes: [
74-
'GridView',
75-
],
73+
deniedTypes: ['GridView'],
7674
) {
7775
setChildrenMixin(children: children);
7876
setClipMixin(clipsContent: clipsContent);
@@ -93,7 +91,7 @@ class GridViewNode extends SinglePlaceholderNode
9391
useCloudDatabase: useCloudDatabase,
9492
collectionPath: collectionPath,
9593
limit: limit,
96-
whereFilters: whereOperations ?? [],
94+
whereFilters: whereFilters ?? [],
9795
orderByFilters: orderByFilters ?? [],
9896
);
9997
}

lib/src/api/nodes/grid_view_node.g.dart

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/api/nodes/list_view_node.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class ListViewNode extends SinglePlaceholderNode
6363
bool useCloudDatabase = false,
6464
String? collectionPath,
6565
int? limit = 20,
66-
List<WhereQueryFilter>? whereOperations,
66+
List<WhereQueryFilter>? whereFilters,
6767
List<OrderByQueryFilter>? orderByFilters,
6868

6969
// [ScrollableMixin] properties.
@@ -100,7 +100,7 @@ class ListViewNode extends SinglePlaceholderNode
100100
useCloudDatabase: useCloudDatabase,
101101
collectionPath: collectionPath,
102102
limit: limit,
103-
whereFilters: whereOperations ?? [],
103+
whereFilters: whereFilters ?? [],
104104
orderByFilters: orderByFilters ?? [],
105105
);
106106
}

lib/src/api/nodes/list_view_node.g.dart

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/api/utils.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ typedef HasNode = bool Function(String id);
1919
/// abstraction to Flutter's [TextPainter].
2020
abstract class ITextSizeCalculator {
2121

22-
/// Disposes this instance of [ITextSizeCalculator].
23-
void dispose();
24-
2522
/// Returns the height of a defined [TextNode] based on its width.
2623
/// The details are dependant on the implementation.
2724
double getHeightForWidth(double width);

0 commit comments

Comments
 (0)