Refactor backoffice fronted dependency inyection

vilasmaciel · vilasmaciel · commit aae93bab4535 · 2020-09-16T18:28:54.000+02:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
     "http-status": "^1.4.2",
     "mandrill-api": "^1.0.45",
     "mongodb": "^3.5.7",
-    "node-dependency-injection": "^2.6.3",
+    "node-dependency-injection": "^2.6.8",
     "nunjucks": "^3.2.1",
     "ts-node": "^8.10.1",
     "typescript": "^3.9.2",
diff --git a/src/apps/backoffice/frontend/config/dependency-injection/Courses/application.yaml b/src/apps/backoffice/frontend/config/dependency-injection/Courses/application.yaml
@@ -0,0 +1,14 @@
+services:
+  Mooc.courses.CourseRepository:
+    class: ../../../../../../Contexts/Mooc/Courses/infrastructure/persistence/MongoCourseRepository
+    arguments: ['@Shared.ConnectionManager']
+
+  Mooc.courses.CourseCreator:
+    class: ../../../../../../Contexts/Mooc/Courses/application/CourseCreator
+    arguments: ['@Mooc.courses.CourseRepository', '@Shared.EventBus']
+
+  Mooc.courses.CreateCourseCommandHandler:
+    class: ../../../../../../Contexts/Mooc/Courses/application/CreateCourseCommandHandler
+    arguments: ['@Mooc.courses.CourseCreator']
+    tags:
+      - { name: 'commandHandler' }
diff --git a/src/apps/backoffice/frontend/config/dependency-injection/CoursesCounter/application.yaml b/src/apps/backoffice/frontend/config/dependency-injection/CoursesCounter/application.yaml
@@ -0,0 +1,24 @@
+services:
+  Mooc.coursesCounter.CoursesCounterFinder:
+    class: ../../../../../../Contexts/Mooc/CoursesCounter/application/Find/CoursesCounterFinder
+    arguments: ['@Mooc.coursesCounter.CoursesCounterRepository']
+
+  Mooc.coursesCounter.CoursesCounterRepository:
+    class: ../../../../../../Contexts/Mooc/CoursesCounter/infrastructure/persistence/mongo/MongoCoursesCounterRepository
+    arguments: ['@Shared.ConnectionManager']
+
+  Mooc.coursesCounter.FindCoursesCounterQueryHandler:
+    class: ../../../../../../Contexts/Mooc/CoursesCounter/application/Find/FindCoursesCounterQueryHandler
+    arguments: ['@Mooc.coursesCounter.CoursesCounterFinder']
+    tags:
+      - { name: 'queryHandler' }
+
+  Mooc.coursesCounter.CoursesCounterIncrementer:
+    class: ../../../../../../Contexts/Mooc/CoursesCounter/application/Increment/CoursesCounterIncrementer
+    arguments: ['@Mooc.coursesCounter.CoursesCounterRepository', '@Shared.EventBus']
+
+  Mooc.coursesCounter.IncrementCoursesCounterOnCourseCreated:
+    class: ../../../../../../Contexts/Mooc/CoursesCounter/application/Increment/IncrementCoursesCounterOnCourseCreated
+    arguments: ['@Mooc.coursesCounter.CoursesCounterIncrementer']
+    tags:
+      - { name: 'domainEventSubscriber' }
diff --git a/src/apps/backoffice/frontend/config/dependency-injection/Shared/application.yaml b/src/apps/backoffice/frontend/config/dependency-injection/Shared/application.yaml
@@ -0,0 +1,30 @@
+services:
+  Shared.Logger:
+    class:  ../../../../../../Contexts/Shared/infrastructure/WinstonLogger
+    arguments: []
+
+  Shared.ConnectionManager:
+    factory:
+      class:  ../../../../../../Contexts/Shared/infrastructure/persistence/mongo/MongoClientFactory
+      method: 'createClient'
+    arguments: ['mooc']
+
+  Shared.EventBus:
+    class:  ../../../../../../Contexts/Shared/infrastructure/EventBus/InMemoryAsyncEventBus
+    arguments: []
+
+  Shared.QueryBus:
+    class:  ../../../../../../Contexts/Shared/infrastructure/QueryBus/InMemoryQueryBus
+    arguments: ['@Shared.QueryHandlersInformation']
+
+  Shared.CommandBus:
+    class:  ../../../../../../Contexts/Shared/infrastructure/CommandBus/InMemoryCommandBus
+    arguments: ['@Shared.CommandHandlersInformation']
+
+  Shared.QueryHandlersInformation:
+    class:  ../../../../../../Contexts/Shared/infrastructure/QueryBus/QueryHandlersInformation
+    arguments: ['!tagged queryHandler']
+
+  Shared.CommandHandlersInformation:
+    class:  ../../../../../../Contexts/Shared/infrastructure/CommandBus/CommandHandlersInformation
+    arguments: ['!tagged commandHandler']
diff --git a/src/apps/backoffice/frontend/config/dependency-injection/application.yaml b/src/apps/backoffice/frontend/config/dependency-injection/application.yaml
@@ -1,82 +1,5 @@
-services:
-  Contexts.shared.Logger:
-    class: ../../../../../Contexts/Shared/infrastructure/WinstonLogger
-    arguments: []
-
-  Apps.Backoffice.Frontend.controllers.HomeGetController:
-    class: ../../controllers/HomeGetController
-
-  Mooc.coursesCounter.CoursesCounterFinder:
-    class: ../../../../../Contexts/Mooc/CoursesCounter/application/Find/CoursesCounterFinder
-    arguments: ['@Mooc.coursesCounter.CoursesCounterRepository']
-
-  Mooc.coursesCounter.CoursesCounterRepository:
-    class: ../../../../../Contexts/Mooc/CoursesCounter/infrastructure/persistence/mongo/MongoCoursesCounterRepository
-    arguments: ['@Mooc.shared.ConnectionManager']
-
-  Mooc.shared.ConnectionManager:
-    factory:
-      class: ../../../../../Contexts/Shared/infrastructure/persistence/mongo/MongoClientFactory
-      method: 'createClient'
-    arguments: ['mooc']
-
-  Mooc.courses.CourseRepository:
-    class: ../../../../../Contexts/Mooc/Courses/infrastructure/persistence/MongoCourseRepository
-    arguments: ['@Mooc.shared.ConnectionManager']
-
-  Mooc.shared.EventBus:
-    class: ../../../../../Contexts/Shared/infrastructure/EventBus/InMemoryAsyncEventBus
-    arguments: []
-
-  Mooc.courses.CourseCreator:
-    class: ../../../../../Contexts/Mooc/Courses/application/CourseCreator
-    arguments: ['@Mooc.courses.CourseRepository', '@Mooc.shared.EventBus']
-
-  Apps.Backoffice.Frontend.controllers.CoursesGetController:
-    class: ../../controllers/CoursesGetController
-    arguments: ['@Mooc.shared.QueryBus']
-
-  Apps.Backoffice.Frontend.controllers.CoursesPostController:
-    class: ../../controllers/CoursesPostController
-    arguments: ['@Mooc.shared.CommandBus']
-
-  Mooc.coursesCounter.FindCoursesCounterQueryHandler:
-    class: ../../../../../Contexts/Mooc/CoursesCounter/application/Find/FindCoursesCounterQueryHandler
-    arguments: ['@Mooc.coursesCounter.CoursesCounterFinder']
-    tags:
-      - { name: 'queryHandler' }
-
-  Mooc.coursesCounter.CoursesCounterIncrementer:
-    class: ../../../../../Contexts/Mooc/CoursesCounter/application/Increment/CoursesCounterIncrementer
-    arguments: [
-      "@Mooc.coursesCounter.CoursesCounterRepository",
-      "@Mooc.shared.EventBus"
-      ]
-
-  Mooc.coursesCounter.IncrementCoursesCounterOnCourseCreated:
-    class: ../../../../../Contexts/Mooc/CoursesCounter/application/Increment/IncrementCoursesCounterOnCourseCreated
-    arguments: ["@Mooc.coursesCounter.CoursesCounterIncrementer"]
-    tags:
-      - { name: 'domainEventSubscriber' }
-
-  Mooc.courses.CreateCourseCommandHandler:
-    class: ../../../../../Contexts/Mooc/Courses/application/CreateCourseCommandHandler
-    arguments: ['@Mooc.courses.CourseCreator']
-    tags:
-      - { name: 'commandHandler' }
-
-  Mooc.shared.QueryBus:
-    class: ../../../../../Contexts/Shared/infrastructure/QueryBus/InMemoryQueryBus
-    arguments: ['@Mooc.shared.QueryHandlersInformation']
-
-  Mooc.shared.CommandBus:
-    class: ../../../../../Contexts/Shared/infrastructure/CommandBus/InMemoryCommandBus
-    arguments: ['@Mooc.shared.CommandHandlersInformation']
-
-  Mooc.shared.QueryHandlersInformation:
-    class: ../../../../../Contexts/Shared/infrastructure/QueryBus/QueryHandlersInformation
-    arguments: ['!tagged queryHandler']
-
-  Mooc.shared.CommandHandlersInformation:
-    class: ../../../../../Contexts/Shared/infrastructure/CommandBus/CommandHandlersInformation
-    arguments: ['!tagged commandHandler']
+imports:
+  - { resource: ./apps/application.yaml }
+  - { resource: ./Shared/application.yaml }
+  - { resource: ./CoursesCounter/application.yaml }
+  - { resource: ./Courses/application.yaml }
diff --git a/src/apps/backoffice/frontend/config/dependency-injection/apps/application.yaml b/src/apps/backoffice/frontend/config/dependency-injection/apps/application.yaml
@@ -0,0 +1,11 @@
+services:
+  Apps.Backoffice.Frontend.controllers.HomeGetController:
+    class:  ../../../controllers/HomeGetController
+
+  Apps.Backoffice.Frontend.controllers.CoursesGetController:
+    class:  ../../../controllers/CoursesGetController
+    arguments: ['@Shared.QueryBus']
+
+  Apps.Backoffice.Frontend.controllers.CoursesPostController:
+    class:  ../../../controllers/CoursesPostController
+    arguments: ['@Shared.CommandBus']
diff --git a/src/apps/backoffice/frontend/seed.ts b/src/apps/backoffice/frontend/seed.ts
@@ -5,7 +5,7 @@ import container from './config/dependency-injection';
 
 export async function seed() {
   const repository: CoursesCounterRepository = container.get('Mooc.coursesCounter.CoursesCounterRepository');
-  const logger = container.get('Contexts.shared.Logger');
+  const logger = container.get('Shared.Logger');
 
   const alreadyExists = await repository.search();
   const isTestEnvironment = process.env.NODE_ENV === 'test';
diff --git a/src/apps/backoffice/frontend/server.ts b/src/apps/backoffice/frontend/server.ts
@@ -12,7 +12,7 @@ app.use(errorHandler());
  * Start Express server.
  */
 const server = app.listen(app.get('port'), async () => {
-  const winstonLogger = container.get('Contexts.shared.Logger');
+  const winstonLogger = container.get('Shared.Logger');
 
   await seed();
 
diff --git a/src/apps/backoffice/frontend/subscribers.ts b/src/apps/backoffice/frontend/subscribers.ts
@@ -5,7 +5,7 @@ import { DomainEventSubscriber } from '../../../Contexts/Shared/domain/DomainEve
 import { DomainEvent } from '../../../Contexts/Shared/domain/DomainEvent';
 
 export function registerSubscribers() {
-  const eventBus = container.get('Mooc.shared.EventBus') as InMemoryAsyncEventBus;
+  const eventBus = container.get('Shared.EventBus') as InMemoryAsyncEventBus;
   const subscriberDefinitions = container.findTaggedServiceIds('domainEventSubscriber') as Map<String, Definition>;
   const subscribers: Array<DomainEventSubscriber<DomainEvent>> = [];
 
diff --git a/src/apps/mooc_backend/config/dependency-injection/Courses/application.yaml b/src/apps/mooc_backend/config/dependency-injection/Courses/application.yaml
@@ -2,14 +2,14 @@ services:
 
   Mooc.courses.CourseRepository:
     class: ../../../../../Contexts/Mooc/Courses/infrastructure/persistence/MongoCourseRepository
-    arguments: ['@Mooc.shared.ConnectionManager']
+    arguments: ['@Shared.ConnectionManager']
 
   Mooc.courses.CourseCreator:
     class: ../../../../../Contexts/Mooc/Courses/application/CourseCreator
-    arguments: ['@Mooc.courses.CourseRepository', '@Mooc.shared.EventBus']
+    arguments: ['@Mooc.courses.CourseRepository', '@Shared.EventBus']
 
   Mooc.courses.CreateCourseCommandHandler:
     class: ../../../../../Contexts/Mooc/Courses/application/CreateCourseCommandHandler
     arguments: ['@Mooc.courses.CourseCreator']
     tags:
-      - { name: 'commandHandler' }
+      - { name: 'commandHandler' }
diff --git a/src/apps/mooc_backend/config/dependency-injection/CoursesCounter/application.yaml b/src/apps/mooc_backend/config/dependency-injection/CoursesCounter/application.yaml
@@ -1,13 +1,13 @@
 services:
   Mooc.coursesCounter.CoursesCounterRepository:
     class: ../../../../../Contexts/Mooc/CoursesCounter/infrastructure/persistence/mongo/MongoCoursesCounterRepository
-    arguments: ["@Mooc.shared.ConnectionManager"]
+    arguments: ["@Shared.ConnectionManager"]
 
   Mooc.coursesCounter.CoursesCounterIncrementer:
     class: ../../../../../Contexts/Mooc/CoursesCounter/application/Increment/CoursesCounterIncrementer
     arguments: [
       "@Mooc.coursesCounter.CoursesCounterRepository",
-      "@Mooc.shared.EventBus"
+      "@Shared.EventBus"
       ]
 
   Mooc.coursesCounter.IncrementCoursesCounterOnCourseCreated:
diff --git a/src/apps/mooc_backend/config/dependency-injection/Shared/application.yaml b/src/apps/mooc_backend/config/dependency-injection/Shared/application.yaml
@@ -1,38 +1,38 @@
 services:
-  Mooc.shared.ConnectionManager:
+  Shared.ConnectionManager:
     factory:
       class: ../../../../../Contexts/Shared/infrastructure/persistence/mongo/MongoClientFactory
       method: 'createClient'
     arguments: ['mooc']
 
-  Mooc.shared.Logger:
+  Shared.Logger:
     class: ../../../../../Contexts/Shared/infrastructure/WinstonLogger
     arguments: []
 
-  Mooc.shared.EventBus:
+  Shared.EventBus:
     class: ../../../../../Contexts/Shared/infrastructure/EventBus/InMemoryAsyncEventBus
     arguments: []
 
-  Mooc.shared.CommandHandlersInformation:
+  Shared.CommandHandlersInformation:
     class: ../../../../../Contexts/Shared/infrastructure/CommandBus/CommandHandlersInformation
     arguments: ['!tagged commandHandler']
 
-  Mooc.shared.CommandBus:
+  Shared.CommandBus:
     class: ../../../../../Contexts/Shared/infrastructure/CommandBus/InMemoryCommandBus
-    arguments: ['@Mooc.shared.CommandHandlersInformation']
+    arguments: ['@Shared.CommandHandlersInformation']
 
-  Mooc.shared.EventBus.DomainEventMapping:
+  Shared.EventBus.DomainEventMapping:
     class: ../../../../../Contexts/Shared/infrastructure/EventBus/DomainEventMapping
     arguments: ['!tagged domainEventSubscriber']
 
-  Mooc.shared.EventBus.DomainEventJsonDeserializer:
+  Shared.EventBus.DomainEventJsonDeserializer:
     class: ../../../../../Contexts/Shared/infrastructure/EventBus/DomainEventJsonDeserializer
-    arguments: ['@Mooc.shared.EventBus.DomainEventMapping']
+    arguments: ['@Shared.EventBus.DomainEventMapping']
 
-  Mooc.shared.QueryHandlersInformation:
+  Shared.QueryHandlersInformation:
     class: ../../../../../Contexts/Shared/infrastructure/QueryBus/QueryHandlersInformation
     arguments: ['!tagged queryHandler']
 
-  Mooc.shared.QueryBus:
+  Shared.QueryBus:
     class: ../../../../../Contexts/Shared/infrastructure/QueryBus/InMemoryQueryBus
-    arguments: ['@Mooc.shared.QueryHandlersInformation']
+    arguments: ['@Shared.QueryHandlersInformation']
diff --git a/src/apps/mooc_backend/config/dependency-injection/application_test.yaml b/src/apps/mooc_backend/config/dependency-injection/application_test.yaml
@@ -4,8 +4,8 @@ imports:
 services:
   Mooc.EnvironmentArranger:
     class: ../../../../../tests/Contexts/Shared/infrastructure/mongo/MongoEnvironmentArranger
-    arguments: ['@Mooc.shared.ConnectionManager']
+    arguments: ['@Shared.ConnectionManager']
 
-  Mooc.shared.EventBus:
+  Shared.EventBus:
     class: ../../../../Contexts/Shared/infrastructure/EventBus/InMemorySyncEventBus
     arguments: []
diff --git a/src/apps/mooc_backend/config/dependency-injection/apps/application.yaml b/src/apps/mooc_backend/config/dependency-injection/apps/application.yaml
@@ -2,12 +2,12 @@ services:
 
   Apps.mooc.controllers.CoursePutController:
     class: ../../../controllers/CoursePutController
-    arguments: ["@Mooc.shared.CommandBus"]
+    arguments: ["@Shared.CommandBus"]
 
   Apps.mooc.controllers.StatusGetController:
     class: ../../../controllers/StatusGetController
     arguments: []
 
   Apps.mooc.controllers.CoursesCounterGetController:
     class: ../../../controllers/CoursesCounterGetController
-    arguments: ["@Mooc.shared.QueryBus"]
+    arguments: ["@Shared.QueryBus"]
diff --git a/src/apps/mooc_backend/server.ts b/src/apps/mooc_backend/server.ts
@@ -12,7 +12,7 @@ app.use(errorHandler());
  */
 const server = app.listen(app.get('port'), () => {
   // tslint:disable: no-console
-  const logger = container.get('Mooc.shared.Logger');
+  const logger = container.get('Shared.Logger');
 
   logger.info(`  App is running at http://localhost:${app.get('port')} in ${app.get('env')} mode`);
   console.log('  Press CTRL-C to stop\n');
diff --git a/src/apps/mooc_backend/subscribers.ts b/src/apps/mooc_backend/subscribers.ts
@@ -5,7 +5,7 @@ import { DomainEventSubscriber } from '../../Contexts/Shared/domain/DomainEventS
 import { DomainEvent } from '../../Contexts/Shared/domain/DomainEvent';
 
 export function registerSubscribers() {
-  const eventBus = container.get('Mooc.shared.EventBus') as InMemoryAsyncEventBus;
+  const eventBus = container.get('Shared.EventBus') as InMemoryAsyncEventBus;
   const subscriberDefinitions = container.findTaggedServiceIds('domainEventSubscriber') as Map<String, Definition>;
   const subscribers: Array<DomainEventSubscriber<DomainEvent>> = [];
 
diff --git a/tests/apps/mooc_backend/features/step_definitions/evenBus.steps.ts b/tests/apps/mooc_backend/features/step_definitions/evenBus.steps.ts
