Add end2end test for filtering courses at the backend courses view

vilasmaciel · vilasmaciel · commit b433d972e38a · 2021-02-07T17:29:54.000+01:00
diff --git a/cypress.json b/cypress.json
@@ -5,5 +5,6 @@
   "testFiles": "**/*.cypress.*",
   "integrationFolder": "tests/apps",
   "fixturesFolder": "tests/utils/cypress/fixtures",
-  "pluginsFile": "tests/utils/cypress/plugins/index.ts"
+  "pluginsFile": "tests/utils/cypress/plugins/index.ts",
+  "experimentalStudio": true
 }
diff --git a/src/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator.ts b/src/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator.ts
@@ -1,4 +1,8 @@
+import { Criteria } from '../../../../Shared/domain/criteria/Criteria';
+import { Filters } from '../../../../Shared/domain/criteria/Filters';
+import { Order } from '../../../../Shared/domain/criteria/Order';
 import { BackofficeCourse } from '../../domain/BackofficeCourse';
+import { BackofficeCourseAlreadyExists } from '../../domain/BackofficeCourseAlreadyExists';
 import { BackofficeCourseDuration } from '../../domain/BackofficeCourseDuration';
 import { BackofficeCourseId } from '../../domain/BackofficeCourseId';
 import { BackofficeCourseName } from '../../domain/BackofficeCourseName';
@@ -14,6 +18,26 @@ export class BackofficeCourseCreator {
       new BackofficeCourseDuration(duration)
     );
 
+    const criteria = this.buildCriteria(id);
+    const alreadyExists = await this.courseAlreadyExists(criteria);
+    if (alreadyExists) {
+      throw new BackofficeCourseAlreadyExists(new BackofficeCourseId(id));
+    }
+
     return this.backofficeCourseRepository.save(course);
   }
+
+  private async courseAlreadyExists(criteria: Criteria) {
+    const current = await this.backofficeCourseRepository.matching(criteria);
+    return current.length > 0;
+  }
+
+  buildCriteria(id: string): Criteria {
+    const filter = new Map<string, string>();
+    filter.set('field', 'id');
+    filter.set('operator', '=');
+    filter.set('value', id);
+    const filters = Filters.fromValues([filter]);
+    return new Criteria(filters, Order.none());
+  }
 }
diff --git a/src/Contexts/Backoffice/Courses/domain/BackofficeCourseAlreadyExists.ts b/src/Contexts/Backoffice/Courses/domain/BackofficeCourseAlreadyExists.ts
@@ -0,0 +1,7 @@
+import { BackofficeCourseId } from './BackofficeCourseId';
+
+export class BackofficeCourseAlreadyExists extends Error {
+  constructor(id: BackofficeCourseId) {
+    super(`Course with id ${id} already exists`);
+  }
+}
diff --git a/src/Contexts/Shared/domain/criteria/FilterOperator.ts b/src/Contexts/Shared/domain/criteria/FilterOperator.ts
@@ -41,4 +41,8 @@ export class FilterOperator extends EnumValueObject<Operator> {
   protected throwErrorForInvalidValue(value: Operator): void {
     throw new InvalidArgumentError(`The filter operator ${value} is invalid`);
   }
+
+  static equal() {
+    return this.fromValue(Operator.EQUAL);
+  }
 }
diff --git a/src/apps/backoffice/frontend/templates/pages/courses/partials/list_courses.html b/src/apps/backoffice/frontend/templates/pages/courses/partials/list_courses.html
@@ -8,6 +8,7 @@ <h3 class="font-sans text-gray-800 text-center text-3xl mb-10">Cursos existentes
   <div class="mt-10 inline-block relative w-2/4">
       <button class="md:w-1/4 bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded focus:outline-none focus:shadow-outline"
               id="add-field-button"
+              data-cy="add-field-button"
               onclick="addFilter(event)">
           Añadir filtro
       </button>
@@ -18,7 +19,7 @@ <h3 class="font-sans text-gray-800 text-center text-3xl mb-10">Cursos existentes
           👉 Filtrar 👈
       </button>
   </div>
-</form> 
+</form>
 
 <table class="text-left w-full border-collapse">
   <thead>
@@ -82,7 +83,7 @@ <h3 class="font-sans text-gray-800 text-center text-3xl mb-10">Cursos existentes
                                 "        <label class=\"block uppercase tracking-wide text-gray-700 text-xs font-bold mb-2\" for=\"field\">\n" +
                                 "            Campo\n" +
                                 "        </label>\n" +
-                                "        <select name=\"filters[" +
+                                "        <select data-cy=\"field-filter\" name=\"filters[" +
                                 totalRows +
                                 "][field]\" id=\"field\"\n" +
                                 "                class=\"block appearance-none w-full bg-white border border-gray-400 hover:border-gray-500 px-4 py-2 pr-8 rounded shadow leading-tight focus:outline-none focus:shadow-outline\">\n" +
@@ -100,7 +101,7 @@ <h3 class="font-sans text-gray-800 text-center text-3xl mb-10">Cursos existentes
                                 "        <label class=\"block uppercase tracking-wide text-gray-700 text-xs font-bold mb-2\" for=\"operator\">\n" +
                                 "            Operador\n" +
                                 "        </label>\n" +
-                                "        <select id=\"operator\" name=\"filters[" +
+                                "        <select data-cy=\"field-filter-type\" id=\"operator\" name=\"filters[" +
                                 totalRows +
                                 "][operator]\"\n" +
                                 "                class=\"block appearance-none w-full bg-white border border-gray-400 hover:border-gray-500 px-4 py-2 pr-8 rounded shadow leading-tight focus:outline-none focus:shadow-outline\">\n" +
@@ -120,7 +121,7 @@ <h3 class="font-sans text-gray-800 text-center text-3xl mb-10">Cursos existentes
                                 "            Valor\n" +
                                 "        </label>\n" +
                                 "        <input class=\"appearance-none block w-full bg-gray-200 text-gray-700 border border-gray-200 rounded py-3 px-4 leading-tight focus:outline-none focus:bg-white focus:border-gray-500\"\n" +
-                                "               id=\"value\" type=\"text\" name=\"filters[" +
+                                "               data-cy=\"filter-value\" id=\"value\" type=\"text\" name=\"filters[" +
                                 totalRows +
                                 "][value]\" placeholder=\"Lo que sea...\">\n" +
                                 "    </div>\n" +
diff --git a/tests/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator.test.ts b/tests/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator.test.ts
@@ -1,6 +1,7 @@
 import { BackofficeCourseCreator } from '../../../../../../src/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator';
-import { BackofficeCourseRepositoryMock } from '../../__mocks__/BackofficeCourseRepositoryMock';
+import { BackofficeCourseAlreadyExists } from '../../../../../../src/Contexts/Backoffice/Courses/domain/BackofficeCourseAlreadyExists';
 import { BackofficeCourseMother } from '../../domain/BackofficeCourseMother';
+import { BackofficeCourseRepositoryMock } from '../../__mocks__/BackofficeCourseRepositoryMock';
 
 describe('BackofficeCourseCreator', () => {
   it('creates a backoffice course', async () => {
@@ -13,4 +14,15 @@ describe('BackofficeCourseCreator', () => {
 
     repository.assertSaveHasBeenCalledWith(course);
   });
+
+  it('throws an error if the course already exists', async () => {
+    const course = BackofficeCourseMother.random();
+    const repository = new BackofficeCourseRepositoryMock();
+    repository.returnMatching([course]);
+    const applicationService = new BackofficeCourseCreator(repository);
+
+    expect(
+      applicationService.run(course.id.toString(), course.duration.toString(), course.name.toString())
+    ).rejects.toBeInstanceOf(BackofficeCourseAlreadyExists);
+  });
 });
diff --git a/tests/apps/backoffice/frontend/features/courses/list_courses.cypress.ts b/tests/apps/backoffice/frontend/features/courses/list_courses.cypress.ts
@@ -1,5 +1,5 @@
 describe('List courses', () => {
-  before(() => {
+  beforeEach(() => {
     cy.task('reset:backoffice:db');
     cy.task('reset:mooc:db');
   });
@@ -25,4 +25,44 @@ describe('List courses', () => {
     cy.get('#courses-list tr').eq(0).should('contain', 'DDD en Typescript');
     cy.get('#courses-list tr').eq(0).should('contain', '25 hours');
   });
+
+  it('can filter courses by its name', () => {
+    createCourses();
+
+    cy.get('button[data-cy="add-field-button"').click();
+    cy.get('[data-cy=field-filter]').select('name');
+    cy.get('[data-cy=field-filter-type]').select('CONTAINS');
+    cy.get('[data-cy=filter-value]').type('Random');
+    cy.get('#filter-button').click();
+
+    cy.contains('Cursos existentes');
+    cy.get('#courses-list').find('tr').should('have.length', 1);
+    cy.get('#courses-list tr').eq(0).should('contain', 'Random Course');
+    cy.get('#courses-list tr').eq(0).should('contain', '2 hours');
+  });
+
+  it('handle invalid filters', () => {
+    createCourses();
+
+    cy.get('button[data-cy="add-field-button"').click();
+    cy.get('[data-cy=field-filter]').select('name');
+    cy.get('[data-cy=field-filter-type]').select('CONTAINS');
+    cy.get('#filter-button').click();
+
+    cy.contains('Cursos existentes');
+    cy.get('#courses-list').find('tr').should('have.length', 1);
+    cy.get('#courses-list tr').eq(0).should('contain', 'Random Course');
+    cy.get('#courses-list tr').eq(0).should('contain', '2 hours');
+  });
 });
+function createCourses() {
+  cy.get('input[name="name"]').type('DDD en Typescript');
+  cy.get('input[name="duration"]').type('25 hours');
+  cy.get('form[data-cy="create-course"]').submit();
+
+  cy.get('input[name="name"]').type('Random Course');
+  cy.get('input[name="duration"]').type('2 hours');
+  cy.get('form[data-cy="create-course"]').submit();
+  cy.wait(1000);
+  cy.reload();
+}

Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,6 @@`
`5`	`5`	`"testFiles": "*/.cypress.*",`
`6`	`6`	`"integrationFolder": "tests/apps",`
`7`	`7`	`"fixturesFolder": "tests/utils/cypress/fixtures",`
`8`		`- "pluginsFile": "tests/utils/cypress/plugins/index.ts"`
	`8`	`+ "pluginsFile": "tests/utils/cypress/plugins/index.ts",`
	`9`	`+ "experimentalStudio": true`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,4 +41,8 @@ export class FilterOperator extends EnumValueObject<Operator> {`
`41`	`41`	`protected throwErrorForInvalidValue(value: Operator): void {`
`42`	`42`	throw new InvalidArgumentError(`The filter operator ${value} is invalid`);
`43`	`43`	`}`
	`44`	`+`
	`45`	`+ static equal() {`
	`46`	`+ return this.fromValue(Operator.EQUAL);`
	`47`	`+ }`
`44`	`48`	`}`