Refactor application entities. Do not start backoffice frontend subscriber

Author: vilasmaciel

package-lock.json

@@ -11,7 +11,7 @@
     "npm": ">=6.7.0"
   },
   "scripts": {
-    "dev": "NODE_ENV=dev ts-node-dev --ignore-watch node_modules --inspect=0.0.0.0:9267 ./src/apps/mooc/backend/start.ts",
+    "dev:mooc:backend": "NODE_ENV=dev ts-node-dev --ignore-watch node_modules  ./src/apps/mooc/backend/start.ts",
     "dev:backoffice:frontend": "NODE_ENV=dev ts-node-dev --ignore-watch node_modules ./src/apps/backoffice/frontend/start.ts",
     "dev:backoffice:backend": "NODE_ENV=dev ts-node-dev --ignore-watch node_modules ./src/apps/backoffice/backend/start.ts",
     "test": "npm run test:unit && npm run test:features && npm run cypress:run",
@@ -31,23 +31,23 @@
     "cypress:run": "NODE_ENV=end2end ts-node tests/utils/cypress/run"
   },
   "dependencies": {
-    "@types/amqplib": "^0.5.16",
+    "@types/amqplib": "^0.5.17",
     "@types/bluebird": "^3.5.33",
     "@elastic/elasticsearch": "^7.10.0",
     "@types/bson": "^4.0.3",
     "@types/compression": "^1.7.0",
-    "@types/convict": "^5.2.1",
+    "@types/convict": "^5.2.2",
     "@types/errorhandler": "1.5.0",
-    "@types/express": "^4.17.9",
+    "@types/express": "^4.17.11",
     "@types/glob": "^7.1.3",
     "@types/helmet": "0.0.48",
-    "@types/mongodb": "^3.5.34",
-    "@types/node": "^14.14.10",
+    "@types/mongodb": "^3.6.3",
+    "@types/node": "^14.14.21",
     "@types/uuid": "^8.3.0",
     "@types/uuid-validate": "0.0.1",
     "amqp-ts": "^1.8.0",
     "body-parser": "^1.19.0",
-    "bson": "^4.2.0",
+    "bson": "^4.2.2",
     "compression": "^1.7.4",
     "connect-flash": "^0.1.1",
     "convict": "^6.0.0",
@@ -57,40 +57,40 @@
     "errorhandler": "^1.5.1",
     "express": "^4.17.1",
     "express-promise-router": "^4.0.1",
-    "express-validator": "^6.7.0",
+    "express-validator": "^6.9.2",
     "glob": "^7.1.6",
-    "helmet": "^4.2.0",
+    "helmet": "^4.3.1",
     "http-status": "^1.5.0",
     "mandrill-api": "^1.0.45",
     "mongodb": "^3.6.3",
     "node-dependency-injection": "^2.6.8",
     "nunjucks": "^3.2.2",
-    "ts-node": "^9.0.0",
-    "typescript": "^4.1.2",
-    "uuid": "^8.3.1",
+    "ts-node": "^9.1.1",
+    "typescript": "^4.1.3",
+    "uuid": "^8.3.2",
     "uuid-validate": "0.0.3",
     "winston": "^3.3.3"
   },
   "devDependencies": {
-    "@types/aws-lambda": "^8.10.64",
+    "@types/aws-lambda": "^8.10.70",
     "@types/connect-flash": "0.0.36",
     "@types/cookie-parser": "^1.4.2",
-    "@types/cookie-session": "^2.0.41",
+    "@types/cookie-session": "^2.0.42",
     "@types/cucumber": "^6.0.1",
-    "@types/faker": "^5.1.4",
-    "@types/jest": "^26.0.15",
+    "@types/faker": "^5.1.5",
+    "@types/jest": "^26.0.20",
     "@types/nunjucks": "^3.1.3",
     "@types/supertest": "^2.0.10",
     "cucumber": "^6.0.5",
-    "cypress": "^6.0.0",
+    "cypress": "^6.2.1",
     "faker": "^5.1.0",
-    "husky": "^4.3.0",
+    "husky": "^4.3.7",
     "jest": "^26.6.3",
-    "lint-staged": "10.5.2",
-    "prettier": "^2.2.0",
-    "supertest": "^6.0.1",
+    "lint-staged": "10.5.3",
+    "prettier": "^2.2.1",
+    "supertest": "^6.1.0",
     "ts-jest": "^26.4.4",
-    "ts-node-dev": "^1.0.0",
+    "ts-node-dev": "^1.1.1",
     "tslint": "^6.1.3",
     "tslint-config-prettier": "~1.18.0",
     "tslint-eslint-rules": "^5.4.0"

package.json

@@ -32,7 +32,6 @@ export default class RabbitMqEventbus implements EventBus {
     await this.queue.activateConsumer(
       async message => {
         const event = this.deserializer!.deserialize(message.content.toString());
-        console.log(`========message ${event?.eventName} in ${this.queue.name}`);
         if (event) {
           const subscribers = this.subscribers.get(event.eventName);
           if (subscribers && subscribers.length) {

src/Contexts/Shared/infrastructure/EventBus/RabbitMq/RabbitMqEventBus.ts

@@ -1,4 +1,9 @@
-import { registerSubscribers } from './subscribers';
+import { Definition } from 'node-dependency-injection';
+import { DomainEvent } from '../../../Contexts/Shared/domain/DomainEvent';
+import { DomainEventSubscriber } from '../../../Contexts/Shared/domain/DomainEventSubscriber';
+import { EventBus } from '../../../Contexts/Shared/domain/EventBus';
+import { DomainEventMapping } from '../../../Contexts/Shared/infrastructure/EventBus/DomainEventMapping';
+import container from './dependency-injection';
 import { Server } from './server';
 
 export class BackofficeBackendApp {
@@ -7,7 +12,7 @@ export class BackofficeBackendApp {
   async start() {
     const port = process.env.PORT || '3000';
     this.server = new Server(port);
-    await registerSubscribers();
+    await this.registerSubscribers();
     return this.server.listen();
   }
 
@@ -21,4 +26,21 @@ export class BackofficeBackendApp {
     }
     return this.server.port;
   }
+
+  get httpServer() {
+    return this.server?.httpServer;
+  }
+
+  private async registerSubscribers() {
+    const eventBus = container.get('Shared.EventBus') as EventBus;
+    const subscriberDefinitions = container.findTaggedServiceIds('domainEventSubscriber') as Map<String, Definition>;
+    const subscribers: Array<DomainEventSubscriber<DomainEvent>> = [];
+
+    subscriberDefinitions.forEach((value: any, key: any) => subscribers.push(container.get(key)));
+    const domainEventMapping = new DomainEventMapping(subscribers);
+
+    eventBus.setDomainEventMapping(domainEventMapping);
+    eventBus.addSubscribers(subscribers);
+    await eventBus.start();
+  }
 }

src/apps/backoffice/backend/BackofficeBackendApp.ts

@@ -21,10 +21,4 @@ services:
     class: ../../../../../Contexts/Shared/infrastructure/EventBus/RabbitMq/RabbitMqEventBus
     arguments: ['@Backoffice.courses.RabbitMqConfig', '@Shared.Logger']
 
-  Shared.EventBus.DomainEventMapping:
-    class: ../../../../../Contexts/Shared/infrastructure/EventBus/DomainEventMapping
-    arguments: ['!tagged domainEventSubscriber']
 
-  Shared.EventBus.DomainEventJsonDeserializer:
-    class: ../../../../../Contexts/Shared/infrastructure/EventBus/DomainEventJsonDeserializer
-    arguments: ['@Shared.EventBus.DomainEventMapping']

src/apps/backoffice/backend/dependency-injection/Shared/application.yaml

@@ -12,7 +12,7 @@ export class Server {
   private express: express.Express;
   readonly port: string;
   private logger: Logger;
-  private httpServer?: http.Server;
+  httpServer?: http.Server;
 
   constructor(port: string) {
     this.port = port;

src/apps/backoffice/backend/server.ts

@@ -1,4 +1,3 @@
-import { registerSubscribers } from './subscribers';
 import { Server } from './server';
 import { seed } from './seed';
 
@@ -8,7 +7,6 @@ export class BackofficeFrontendApp {
   async start() {
     const port = process.env.PORT || '8032';
     this.server = new Server(port);
-    await registerSubscribers();
     await seed();
     return this.server.listen();
   }

src/apps/backoffice/backend/subscribers.ts

@@ -41,13 +41,11 @@ <h3 class="font-sans text-gray-800 text-center text-3xl mb-10">Cursos existentes
 
 <script>
   function addCoursesList(url) {
-      console.log(url);
 
       const tableBody = document.getElementById("courses-list");
 
       fetch(url)
           .then(function (response) {
-              console.log(response)
               return response.json();
           })
           .then(function (courses) {