Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Last PR triggers errors when file does not exists in system.Β #4

@ulinskas

Description

@ulinskas

This PR https://github.com/Litipk/flysystem-fallback-adapter/pull/2 created issue, you should revert these changes.

How it was before:

if ($this->mainAdapter->has($path)) {
    return $this->mainAdapter->read($path);
}

How it is now:

$result = $this->mainAdapter->read($path);
if (false !== $result) {
    return $result;
}

I agree that this changes save some performance. But now, you get warning if file does not exists in system (If errors are not suppressed)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions