Increased code coverage

castarco · castarco · commit 036fe0ecfdc3 · 2014-01-26T17:31:08.000+01:00
diff --git a/src/Decimal.php b/src/Decimal.php
@@ -411,7 +411,7 @@ public function sqrt($scale = null)
     {
         if ($this->isNegative()) {
             throw new \DomainException(
-                "Decimal can't handle square roots of negative numbers (it's only for real numbers)"
+                "Decimal can't handle square roots of negative numbers (it's only for real numbers)."
             );
         } elseif ($this->isZero()) {
             return Decimal::fromDecimal($this, $scale);
diff --git a/tests/Decimal/DecimalAbsTest.php b/tests/Decimal/DecimalAbsTest.php
@@ -2,12 +2,27 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalAbsTest extends PHPUnit_Framework_TestCase
 {
-    public function testBaseCase()
+    public function testFiniteAbs()
     {
         $this->assertTrue(Decimal::fromInteger(0)->abs()->equals(Decimal::fromInteger(0)));
         $this->assertTrue(Decimal::fromInteger(5)->abs()->equals(Decimal::fromInteger(5)));
         $this->assertTrue(Decimal::fromInteger(-5)->abs()->equals(Decimal::fromInteger(5)));
     }
+
+    public function testInfiniteAbs()
+    {
+    	$this->assertTrue(
+    		Decimal::getPositiveInfinite()->abs()->equals(Decimal::getPositiveInfinite())
+    	);
+
+    	$this->assertTrue(
+    		Decimal::getNegativeInfinite()->abs()->equals(Decimal::getPositiveInfinite())
+    	);
+    }
 }
diff --git a/tests/Decimal/DecimalAddTest.php b/tests/Decimal/DecimalAddTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalAddTest extends PHPUnit_Framework_TestCase
 {
     public function testZeroAdd()
diff --git a/tests/Decimal/DecimalAdditiveInverseTest.php b/tests/Decimal/DecimalAdditiveInverseTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalAdditiveInverseTest extends PHPUnit_Framework_TestCase
 {
     public function testZeroAdditiveInverse()
diff --git a/tests/Decimal/DecimalCompTest.php b/tests/Decimal/DecimalCompTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalCompTest extends PHPUnit_Framework_TestCase
 {
     public function testSelfComp()
diff --git a/tests/Decimal/DecimalCreateTest.php b/tests/Decimal/DecimalCreateTest.php
@@ -3,8 +3,12 @@
 use Litipk\BigNumbers\Decimal as Decimal;
 use Litipk\Exceptions\InvalidArgumentTypeException;
 
-// Empty class used for testing
-class A {}
+
+date_default_timezone_set('UTC');
+
+
+class A {}  // Empty class used for testing
+
 
 class DecimalCreateTest extends PHPUnit_Framework_TestCase
 {
diff --git a/tests/Decimal/DecimalDivTest.php b/tests/Decimal/DecimalDivTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalDivTest extends PHPUnit_Framework_TestCase
 {
     public function testZeroFiniteDiv()
diff --git a/tests/Decimal/DecimalEqualsTest.php b/tests/Decimal/DecimalEqualsTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalEqualsTest extends PHPUnit_Framework_TestCase
 {
     public function testNotEquals()
diff --git a/tests/Decimal/DecimalFromDecimalTest.php b/tests/Decimal/DecimalFromDecimalTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalFromDecimalTest extends PHPUnit_Framework_TestCase
 {
     public function testBasicCase()
diff --git a/tests/Decimal/DecimalFromFloatTest.php b/tests/Decimal/DecimalFromFloatTest.php
@@ -1,7 +1,10 @@
 <?php
 
 use Litipk\BigNumbers\Decimal as Decimal;
-use Litipk\BigNumbers\NaN as NaN;
+
+
+date_default_timezone_set('UTC');
+
 
 class DecimalFromFloatTest extends PHPUnit_Framework_TestCase
 {
diff --git a/tests/Decimal/DecimalFromIntegerTest.php b/tests/Decimal/DecimalFromIntegerTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalFromIntegerTest extends PHPUnit_Framework_TestCase
 {
     public function testNoInteger()
diff --git a/tests/Decimal/DecimalFromStringTest.php b/tests/Decimal/DecimalFromStringTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalFromStringTest extends PHPUnit_Framework_TestCase
 {
     public function testNegativeSimpleString()
diff --git a/tests/Decimal/DecimalInternalValidationTest.php b/tests/Decimal/DecimalInternalValidationTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalInternalValidationTest extends PHPUnit_Framework_TestCase
 {
     public function testInternalConstructorValidation()
diff --git a/tests/Decimal/DecimalIsZeroTest.php b/tests/Decimal/DecimalIsZeroTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalIsZeroTest extends PHPUnit_Framework_TestCase
 {
     public function testZeros()
diff --git a/tests/Decimal/DecimalLog10Test.php b/tests/Decimal/DecimalLog10Test.php
@@ -2,9 +2,13 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalLog10Test extends PHPUnit_Framework_TestCase
 {
-    public function testZero()
+    public function testZeroLog10()
     {
         $zero = Decimal::fromInteger(0);
 
@@ -14,7 +18,7 @@ public function testZero()
         $this->assertTrue($zero_log->isInfinite());
     }
 
-    public function testNegative()
+    public function testNegativeLog10()
     {
         $nOne = Decimal::fromInteger(-1);
 
@@ -27,28 +31,35 @@ public function testNegative()
         $this->assertTrue($catched);
     }
 
-    public function testBigNumbers()
+    public function testBigNumbersLog10()
     {
         $bignumber = Decimal::fromString(bcpow('10', '2417'));
         $pow = Decimal::fromInteger(2417);
 
         $this->assertTrue($bignumber->log10()->equals($pow));
     }
 
-    public function testLittleNumbers()
+    public function testLittleNumbersLog10()
     {
         $littlenumber = Decimal::fromString(bcpow('10', '-2417', 2417));
         $pow = Decimal::fromInteger(-2417);
 
         $this->assertTrue($littlenumber->log10()->equals($pow));
     }
 
-    public function testMediumNumbers()
+    public function testMediumNumbersLog10()
     {
         $seventyfive = Decimal::fromInteger(75);
         $fortynine = Decimal::fromInteger(49);
 
         $this->assertTrue($seventyfive->log10(5)->equals(Decimal::fromString('1.87506')));
         $this->assertTrue($fortynine->log10(7)->equals(Decimal::fromString('1.6901961')));
     }
+
+    public function testPInfiniteLog10()
+    {
+        $pInf = Decimal::getPositiveInfinite();
+
+        $this->assertTrue($pInf->log10()->equals($pInf));
+    }
 }
diff --git a/tests/Decimal/DecimalMulTest.php b/tests/Decimal/DecimalMulTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalMulTest extends PHPUnit_Framework_TestCase
 {
     public function testZeroFiniteMul()
@@ -19,43 +23,52 @@ public function testZeroFiniteMul()
         $this->assertTrue($r2->isZero());
     }
 
-    public function testZeroInfiniteMul()
+    /**
+     * @expectedException \DomainException
+     * @expectedExceptionMessage Zero multiplied by infinite is not allowed.
+     */
+    public function testZeroPInfiniteMul()
+    {
+        $pInf = Decimal::getPositiveInfinite();
+        $zero = Decimal::fromInteger(0);
+
+        $zero->mul($pInf);
+    }
+
+    /**
+     * @expectedException \DomainException
+     * @expectedExceptionMessage Zero multiplied by infinite is not allowed.
+     */
+    public function testZeroNInfiniteMul()
+    {
+        $nInf = Decimal::getNegativeInfinite();
+        $zero = Decimal::fromInteger(0);
+
+        $zero->mul($nInf);
+    }
+
+    /**
+     * @expectedException \DomainException
+     * @expectedExceptionMessage Zero multiplied by infinite is not allowed.
+     */
+    public function testPInfiniteZeroMul()
     {
         $pInf = Decimal::getPositiveInfinite();
+        $zero = Decimal::fromInteger(0);
+
+        $pInf->mul($zero);
+    }
+
+    /**
+     * @expectedException \DomainException
+     * @expectedExceptionMessage Zero multiplied by infinite is not allowed.
+     */
+    public function testNInfiniteZeroMul()
+    {
         $nInf = Decimal::getNegativeInfinite();
         $zero = Decimal::fromInteger(0);
 
-        $catched = false;
-        try {
-            $pInf->mul($zero);
-        } catch (\DomainException $e) {
-            $catched = true;
-        }
-        $this->assertTrue($catched);
-
-        $catched = false;
-        try {
-            $nInf->mul($zero);
-        } catch (\DomainException $e) {
-            $catched = true;
-        }
-        $this->assertTrue($catched);
-
-        $catched = false;
-        try {
-            $zero->mul($pInf);
-        } catch (\DomainException $e) {
-            $catched = true;
-        }
-        $this->assertTrue($catched);
-
-        $catched = false;
-        try {
-            $zero->mul($nInf);
-        } catch (\DomainException $e) {
-            $catched = true;
-        }
-        $this->assertTrue($catched);
+        $nInf->mul($zero);
     }
 
     public function testSignsMul()
diff --git a/tests/Decimal/DecimalPowTest.php b/tests/Decimal/DecimalPowTest.php
@@ -3,6 +3,10 @@
 use Litipk\BigNumbers\Decimal as Decimal;
 use Litipk\Exceptions\NotImplementedException as NotImplementedException;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalPowTest extends PHPUnit_Framework_TestCase
 {
     public function testZeroPositive()
diff --git a/tests/Decimal/DecimalRoundTest.php b/tests/Decimal/DecimalRoundTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalRoundTest extends PHPUnit_Framework_TestCase
 {
     public function testIntegerRound()
diff --git a/tests/Decimal/DecimalSerializationTest.php b/tests/Decimal/DecimalSerializationTest.php
@@ -2,6 +2,10 @@
 
 use Litipk\BigNumbers\Decimal as Decimal;
 
+
+date_default_timezone_set('UTC');
+
+
 class DecimalSerializationTest extends PHPUnit_Framework_TestCase
 {
     public function testBaseCase()
diff --git a/tests/Decimal/DecimalSqrtTest.php b/tests/Decimal/DecimalSqrtTest.php
diff --git a/tests/Decimal/DecimalSubTest.php b/tests/Decimal/DecimalSubTest.php

Original file line number	Diff line number	Diff line change
`@@ -411,7 +411,7 @@ public function sqrt($scale = null)`
`411`	`411`	`{`
`412`	`412`	`if ($this->isNegative()) {`
`413`	`413`	`throw new \DomainException(`
`414`		`- "Decimal can't handle square roots of negative numbers (it's only for real numbers)"`
	`414`	`+ "Decimal can't handle square roots of negative numbers (it's only for real numbers)."`
`415`	`415`	`);`
`416`	`416`	`} elseif ($this->isZero()) {`
`417`	`417`	`return Decimal::fromDecimal($this, $scale);`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,10 @@`
`2`	`2`
`3`	`3`	`use Litipk\BigNumbers\Decimal as Decimal;`
`4`	`4`
	`5`	`+`
	`6`	`+date_default_timezone_set('UTC');`
	`7`	`+`
	`8`	`+`
`5`	`9`	`class DecimalAddTest extends PHPUnit_Framework_TestCase`
`6`	`10`	`{`
`7`	`11`	`public function testZeroAdd()`