SNOW-1889398: Handle endpoint without protocol for GCS (snowflakedb#1080)

sfc-gh-dprzybysz · web-flow · commit ae9f693406e4 · 2025-01-20T10:48:29.000+01:00
diff --git a/Snowflake.Data/Core/FileTransfer/StorageClient/SFGCSClient.cs b/Snowflake.Data/Core/FileTransfer/StorageClient/SFGCSClient.cs
@@ -91,7 +91,7 @@ private Google.Cloud.Storage.V1.StorageClient BuildStorageClient(StorageClientBu
         {
             var gcsCustomEndpoint = stageInfo.GcsCustomEndpoint();
             if (!string.IsNullOrEmpty(gcsCustomEndpoint))
-                builder.BaseUri = gcsCustomEndpoint;
+                builder.BaseUri = gcsCustomEndpoint.StartsWith("https://") ? gcsCustomEndpoint : "https://" + gcsCustomEndpoint;
             return builder.Build();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ private Google.Cloud.Storage.V1.StorageClient BuildStorageClient(StorageClientBu`
`91`	`91`	`{`
`92`	`92`	`var gcsCustomEndpoint = stageInfo.GcsCustomEndpoint();`
`93`	`93`	`if (!string.IsNullOrEmpty(gcsCustomEndpoint))`
`94`		`- builder.BaseUri = gcsCustomEndpoint;`
	`94`	`+ builder.BaseUri = gcsCustomEndpoint.StartsWith("https://") ? gcsCustomEndpoint : "https://" + gcsCustomEndpoint;`
`95`	`95`	`return builder.Build();`
`96`	`96`	`}`
`97`	`97`