Bugfix: ShowComponentHierarchy no longer fails when the Angular application contains recursive component.

Author: CoderAllan

CHANGELOG.md

@@ -1,8 +1,12 @@
 # Change Log
 
+## Version 1.2.2
+
+- Fixed bug: Show component hierarchy no longer fails when the Angular application contains recursive component.
+
 ## Version 1.2.1
 
--Fixed bug in Readme.md
+- Fixed bug in Readme.md
 
 ## Version 1.2.0
 

package.json

@@ -4,7 +4,7 @@
 	"displayName": "AngularTools",
 	"description": "AngularTools is a collection of tools for exploring an Angular project, help you with documenting, reverse engineering a project or help when refactoring.",
 	"icon": "images/logo.png",
-	"version": "1.2.1",
+	"version": "1.2.2",
 	"repository": "https://github.com/CoderAllan/vscode-angulartools",
 	"author": {
 		"name": "Allan Simonsen",

src/commands/showComponentHierarchy.ts

@@ -112,17 +112,19 @@ export class ShowComponentHierarchy {
     for (let selector in componentHash) {
       const component = componentHash[selector];
       if (component.isRoot) {
-        this.generateDirectedGraphNodes(component.subComponents, component, true, appendNodes);
+        this.generateDirectedGraphNodes(component.subComponents, component, true, '', appendNodes);
         this.generateDirectedGraphEdges(component.subComponents, selector, "", appendLinks);
       }
     }
   }
 
-  private generateDirectedGraphNodes(components: Component[], component: Component, isRoot: boolean, appendNodes: (nodeList: Node[]) => void) {
+  private generateDirectedGraphNodes(components: Component[], component: Component, isRoot: boolean, parentSelector: string, appendNodes: (nodeList: Node[]) => void) {
     appendNodes([new Node(component.selector, component.templateFilename, isRoot)]);
     if (components.length > 0) {
       components.forEach((subComponent) => {
-        this.generateDirectedGraphNodes(subComponent.subComponents, subComponent, subComponent.isRoot, appendNodes);
+        if(parentSelector !== subComponent.selector) {
+          this.generateDirectedGraphNodes(subComponent.subComponents, subComponent, subComponent.isRoot, component.selector, appendNodes);
+        }
       });
     }
   }
@@ -132,7 +134,7 @@ export class ShowComponentHierarchy {
       const id = Math.random() * 100000;
       appendLinks([new Edge(id.toString(), parentSelector, selector)]);
     }
-    if (subComponents.length > 0) {
+    if (subComponents.length > 0 && selector !== parentSelector) {
       subComponents.forEach((subComponent) => {
         this.generateDirectedGraphEdges(subComponent.subComponents, subComponent.selector, selector, appendLinks);
       });